Opened 4 years ago

Closed 4 years ago

#18870 closed enhancement (invalid)

Use Cython arrays instead of sage_malloc()

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: cython Keywords:
Cc: ncohen Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/ticket/18870 (Commits) Commit: b159394988c047a1f1c66ce45e17574c6d9006dd
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Discuss using Cython arrays instead of C arrays with manual malloc()/free() calls.

Change History (8)

comment:1 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/18870

comment:3 Changed 4 years ago by jdemeyer

  • Commit set to 9adebba38007562448e0c2832c3a5e9e2e004e09

New commits:

9adebbaUse Cython array to allocate bfs_reorder

comment:4 Changed 4 years ago by git

  • Commit changed from 9adebba38007562448e0c2832c3a5e9e2e004e09 to b159394988c047a1f1c66ce45e17574c6d9006dd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b159394Use Cython array to allocate bfs_reorder

comment:5 Changed 4 years ago by jdemeyer

This works. Accessing the array is as fast as a C array (provided you disable boundscheck and wraparound), but allocating it is ugly. I don't like it.

comment:6 Changed 4 years ago by jdemeyer

  • Authors Jeroen Demeyer deleted
  • Milestone changed from sage-6.8 to sage-duplicate/invalid/wontfix
  • Reviewers set to Jeroen Demeyer
  • Status changed from new to needs_review

Close as "not a good idea".

comment:7 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:8 Changed 4 years ago by vbraun

  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.