Opened 4 years ago

Last modified 4 years ago

## #18861 new defect

# Three apparently useless polyhedron methods

Reported by: | ncohen | Owned by: | |
---|---|---|---|

Priority: | major | Milestone: | sage-6.8 |

Component: | geometry | Keywords: | |

Cc: | dimpase, vbraun, vdelecroix | Merged in: | |

Authors: | Reviewers: | ||

Report Upstream: | N/A | Work issues: | |

Branch: | Commit: | ||

Dependencies: | Stopgaps: |

### Description

It seems that the three following functions are not used anywhere

(polgraph|✚2…)~/sage/geometry$ grep _make_polyh . -R ./polyhedron/base.py:# _make_polyhedron_face. ./polyhedron/base.py: def _make_polyhedron_face(self, Vindices, Hindices): ./polyhedron/base.py: sage: square._make_polyhedron_face((0,2), (1,)) ./polyhedron/base.py: return self._make_polyhedron_face(Vindices, Hindices) (polgraph|✚2…)~/sage/geometry$ grep _init_fac . -R ./polyhedron/base.py:# _init_facet_adjacency_matrix, _init_vertex_adjacency_matrix, and ./polyhedron/backend_cdd.py: def _init_facet_adjacency_matrix(self, verbose=False): ./polyhedron/backend_cdd.py: sage: p._init_facet_adjacency_matrix() (polgraph|✚2…)~/sage/geometry$ grep _init_vertex . -R ./polyhedron/base.py:# _init_facet_adjacency_matrix, _init_vertex_adjacency_matrix, and ./polyhedron/backend_cdd.py: def _init_vertex_adjacency_matrix(self, verbose=False): ./polyhedron/backend_cdd.py: sage: p._init_vertex_adjacency_matrix()

Should they be removed, or used somewhere?

Nathann

**Note:**See TracTickets for help on using tickets.

`_make_polyhedron_face`

is used in`face_lattice`

.