Opened 6 years ago

Closed 6 years ago

#18854 closed defect (fixed)

Uninitialized values returned by diameter_lower_bound_multi_sweep

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.8
Component: graph theory Keywords:
Cc: ncohen, dcoudert Merged in:
Authors: Jean-Pierre Flori Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: b6188ce (Commits, GitHub, GitLab) Commit: b6188ce6476c09ea544a88d3bfc9cee21745886d
Dependencies: Stopgaps:

Status badges

Description

This only happens when the main loop is not entered. At least on ppc64 this results in Cython potentially trying to make a unit32_t from a long which overflows.

Change History (4)

comment:1 Changed 6 years ago by jpflori

  • Branch set to u/jpflori/ticket/18854
  • Commit set to b6188ce6476c09ea544a88d3bfc9cee21745886d
  • Status changed from new to needs_review

New commits:

b6188ceMake sure values returned by diameter_lower_bound_multi_sweep are initialized.

comment:2 Changed 6 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

I agree with your patch. Thank you for identifying the problem and solving it. David.

comment:3 Changed 6 years ago by ncohen

Thaaaaaaaaaaaaaaaaaaaaanks !!!

Nathann

comment:4 Changed 6 years ago by vbraun

  • Branch changed from u/jpflori/ticket/18854 to b6188ce6476c09ea544a88d3bfc9cee21745886d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.