Opened 7 years ago

Closed 7 years ago

#18837 closed enhancement (fixed) remove foo_depends variables

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-6.8
Component: cython Keywords:
Cc: jpflori Merged in:
Authors: Jeroen Demeyer Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: 37a7a10 (Commits, GitHub, GitLab) Commit: 37a7a107a1e763164f857e19b81f8726ee57a3df
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

These days, Cython knows that included files are a dependency. So in most cases, the

depends = [...]

lines in are not needed.

This ticket removes flint_depends, singular_depends and givaro_depends with one exception: the dependency of sage.libs.linbox.linbox on Givaro is not automatically detected (I don't know whether it's a real dependency, but I'm keeping the explicit dependency to be safe).

To check that Cython really knows the dependencies, you can check the metadata on top of each generated .c/.cpp file. You will see that (with the one exception mentioned before), Cython knows the dependencies.

Note that in some cases, flint/flint.h was a dependency before but not after this ticket. In all those cases, other FLINT files like flint/ulong_extras.h are still a dependency, so this is not a problem.

Change History (4)

comment:1 Changed 7 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/18837

comment:2 Changed 7 years ago by jdemeyer

  • Cc jpflori added
  • Commit set to 37a7a107a1e763164f857e19b81f8726ee57a3df
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

37a7a10Remove foo_depends variables

comment:3 Changed 7 years ago by jpflori

  • Reviewers set to Jean-Pierre Flori
  • Status changed from needs_review to positive_review

comment:4 Changed 7 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/18837 to 37a7a107a1e763164f857e19b81f8726ee57a3df
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.