Opened 4 years ago

Closed 4 years ago

#18829 closed enhancement (fixed)

Add a hint in the automatic doctest sig_on_count()

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.8
Component: doctest framework Keywords:
Cc: dcoudert Merged in:
Authors: Nathann Cohen Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 2e666dd (Commits) Commit: 2e666dd6f63cab6a3cb0a31de9674faf718f1306
Dependencies: Stopgaps:

Description

While working on #18746, I met a doctest error for a doctest that never appeared in my file. I looked at it for a while before undersdtanding what was happening. This branch adds the 'hint' I needed at that time.

Nathann

Change History (10)

comment:1 Changed 4 years ago by ncohen

  • Branch set to u/ncohen/18829
  • Commit set to b70e19ee4ae9ebcd648c7e7719bd9637feedb033

New commits:

b70e19etrac #18829: Add a hint in the automatic doctest sig_on_count()

comment:2 Changed 4 years ago by dcoudert

Shouldn't you set this patch to needs review?

I assume than for testing it we have no choice but doctesting the full src/sage/ directory. Right?

comment:3 Changed 4 years ago by ncohen

Agggggg, I am an idiot. I had started all tests when I created the branch, and this morning I closed a remote ssh session without knowing what it had been testing. It was probably this patch. I'll re-run the tests T_T

comment:4 Changed 4 years ago by git

  • Commit changed from b70e19ee4ae9ebcd648c7e7719bd9637feedb033 to d42c0a4631d80ccd34029e24cb085f2a2bfafaac

Branch pushed to git repo; I updated commit sha1. New commits:

ca2980ftrac #18829: Merged with 6.8.beta7
d42c0a4trac #18829: Broken doctests

comment:5 Changed 4 years ago by ncohen

  • Status changed from new to needs_review

comment:6 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Can you just define a string constant for

"sig_on_count() # check sig_on/off pairings (virtual doctest)\n"

instead of writing the same string several times.

comment:7 Changed 4 years ago by ncohen

  • Status changed from needs_work to needs_review

Done !

For this kind of trivial changes, it is not too daring for a reviewer to propose a commit ^^;

Nathann

comment:8 Changed 4 years ago by git

  • Commit changed from d42c0a4631d80ccd34029e24cb085f2a2bfafaac to 2e666dd6f63cab6a3cb0a31de9674faf718f1306

Branch pushed to git repo; I updated commit sha1. New commits:

2e666ddtrac #18829: One string to rule them all

comment:9 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review
  • Type changed from defect to enhancement

comment:10 Changed 4 years ago by vbraun

  • Branch changed from u/ncohen/18829 to 2e666dd6f63cab6a3cb0a31de9674faf718f1306
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.