Opened 4 years ago

Closed 4 years ago

#18827 closed enhancement (fixed)

new style packaging for csdp

Reported by: dimpase Owned by:
Priority: major Milestone: sage-6.8
Component: packages: experimental Keywords:
Cc: ncohen Merged in:
Authors: Dima Pasechnik Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 4af5064 (Commits) Commit: 4af50645f8a7e9f10aeeb13367076a64cdd19258
Dependencies: Stopgaps:

Description (last modified by ncohen)

create the usual stuff for a new style pkg, and add spkg-src to create the tarfile.

download the upstream tar from ​http://users.ox.ac.uk/~coml0531/sage/csdp-6.2.tar.gz

Ask Harald to move the old .spkg to archive/

Change History (8)

comment:1 Changed 4 years ago by dimpase

  • Branch set to u/dimpase/18827
  • Commit set to 8a56f196459441c512ae4cc040c753e9c15c689e
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to needs_work

The SPKG.txt file is missing. Short of that, it does what it is meant to do: turn the old spkg file into a new-style package.

Let's not forget to email Harald about the change when the ticket will be merged.

Nathann

comment:3 Changed 4 years ago by git

  • Commit changed from 8a56f196459441c512ae4cc040c753e9c15c689e to 72569561f3db66dcaff278942e892a2f669b2071

Branch pushed to git repo; I updated commit sha1. New commits:

​7256956fix the dirname of the tarfile

comment:4 Changed 4 years ago by git

  • Commit changed from 72569561f3db66dcaff278942e892a2f669b2071 to 602ed1a041e4e0a8ec5878d1280f4a5e0a18782f

Branch pushed to git repo; I updated commit sha1. New commits:

​602ed1aadded SPKG.txt

comment:5 Changed 4 years ago by dimpase

  • Status changed from needs_work to needs_review

comment:6 Changed 4 years ago by git

  • Commit changed from 602ed1a041e4e0a8ec5878d1280f4a5e0a18782f to 4af50645f8a7e9f10aeeb13367076a64cdd19258

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​4af5064added SPKG.txt

comment:7 Changed 4 years ago by ncohen

  • Description modified (diff)
  • Status changed from needs_review to positive_review

Okayyyyyy, good to go!

Nathann

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/dimpase/18827 to 4af50645f8a7e9f10aeeb13367076a64cdd19258
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.