Opened 7 years ago

Closed 6 years ago

#18800 closed enhancement (fixed)

Implement a method in ClusterSeed for presenting the upper bound algebra

Reported by: jmatherne Owned by:
Priority: minor Milestone: sage-7.4
Component: combinatorics Keywords: cluster, SageDays64.5, upper bound
Cc: etn40ff, gmoose05, egunawan, aram.dermenjian Merged in:
Authors: Jacob P. Matherne, Matthew R. Mills, Greg Muller, Harold Williams Reviewers: Gregg Musiker
Report Upstream: N/A Work issues:
Branch: 3676fd5 (Commits, GitHub, GitLab) Commit: 3676fd5080b962a72a11217fa5cef86f692f90c1
Dependencies: Stopgaps:

Status badges

Description (last modified by jmatherne)

Adds a find_upper_bound method to ClusterSeed. This method implements the algorithm in arXiv:1307.0579 for giving a presentation of the upper bound algebra in terms of generators and relations.

It inputs a ClusterSeed and outputs the upper bound algebra as a quotient_ring.

Attachments (1)

cluster_seed.py (91.0 KB) - added by jmatherne 7 years ago.

Download all attachments as: .zip

Change History (18)

Changed 7 years ago by jmatherne

comment:1 Changed 7 years ago by jmatherne

  • Description modified (diff)

comment:2 Changed 7 years ago by jmatherne

  • Description modified (diff)

comment:3 Changed 7 years ago by jmatherne

  • Component changed from commutative algebra to combinatorics

comment:4 Changed 7 years ago by jmatherne

  • Cc etn40ff added

comment:5 Changed 7 years ago by jmatherne

  • Status changed from new to needs_review

comment:6 Changed 7 years ago by chapoton

  • Status changed from needs_review to needs_work

you need to provide a git branch, not an attachment

comment:7 Changed 7 years ago by chapoton

  • Branch set to public/ticket/18800
  • Commit set to 070c91635e7153404b99b57246ec38755c350d54
  • Status changed from needs_work to needs_review

I have made a git branch for you, and cleaned-up the code.


New commits:

7321de5trac #18800 upper bounds of cluster algebras
070c916trac #18800 clean-up and simplifications

comment:8 Changed 7 years ago by chapoton

  • Milestone changed from sage-6.8 to sage-6.9

comment:9 Changed 7 years ago by jmatherne

Thank you for all the work and help. It is much appreciated! The code is a lot cleaner now.

comment:10 Changed 7 years ago by tscrim

  • Cc gmoose05 egunawan added

comment:11 Changed 7 years ago by git

  • Commit changed from 070c91635e7153404b99b57246ec38755c350d54 to 8703225be454d1b92a7ada657226f4371e658e90

Branch pushed to git repo; I updated commit sha1. New commits:

8703225Merge branch 'public/ticket/18800' into 6.10.beta2

comment:12 Changed 6 years ago by git

  • Commit changed from 8703225be454d1b92a7ada657226f4371e658e90 to ea2233a17490b73bd49161691da404660a764c17

Branch pushed to git repo; I updated commit sha1. New commits:

bef8211Merge branch 'public/ticket/18800' into 7.3.b4
ea2233atrac 18800 py3 print

comment:13 Changed 6 years ago by egunawan

  • Cc aram.dermenjian added

comment:14 Changed 6 years ago by git

  • Commit changed from ea2233a17490b73bd49161691da404660a764c17 to 3676fd5080b962a72a11217fa5cef86f692f90c1

Branch pushed to git repo; I updated commit sha1. New commits:

3676fd5Merge branch 'public/ticket/18800' of git://trac.sagemath.org/sage into public/ticket/18800

comment:15 Changed 6 years ago by chapoton

  • Milestone changed from sage-6.9 to sage-7.4

bot is green. That would be a good time for a review.

comment:16 Changed 6 years ago by gmoose05

  • Reviewers set to Gregg Musiker
  • Status changed from needs_review to positive_review

Computations seem to behave as I expected. Since the bot is green, I think we're good to go.

comment:17 Changed 6 years ago by vbraun

  • Branch changed from public/ticket/18800 to 3676fd5080b962a72a11217fa5cef86f692f90c1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.