Opened 5 years ago

Closed 5 years ago

#18795 closed defect (fixed)

Fix parent class of a base extension of formal sums

Reported by: SimonKing Owned by:
Priority: major Milestone: sage-6.8
Component: categories Keywords: formal sum, category, parent class
Cc: nthiery Merged in:
Authors: Simon King Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: a339a7c (Commits) Commit: a339a7cd7f225e0d3ef05ca1758783de5087be9c
Dependencies: Stopgaps:

Description

The following is a bug that becomes critical in #18758:

sage: FormalSums(ZZ).base_extend(GF(7))
Abelian Group of all Formal Finite Sums over Finite Field of size 7
sage: isinstance(_, _.category().parent_class)
False

Change History (4)

comment:1 Changed 5 years ago by SimonKing

  • Branch set to u/SimonKing/fix_parent_class_of_a_base_extension_of_formal_sums

comment:2 Changed 5 years ago by SimonKing

  • Authors set to Simon King
  • Commit set to a339a7cd7f225e0d3ef05ca1758783de5087be9c
  • Status changed from new to needs_review

New commits:

a339a7cFix FormalSums with respect to category framework

comment:3 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 5 years ago by vbraun

  • Branch changed from u/SimonKing/fix_parent_class_of_a_base_extension_of_formal_sums to a339a7cd7f225e0d3ef05ca1758783de5087be9c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.