#18785 closed enhancement (fixed)
chang graphs
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.8 |
Component: | graph theory | Keywords: | |
Cc: | dimpase | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | David Coudert |
Report Upstream: | N/A | Work issues: | |
Branch: | 6554017 (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description
The chang graphs are a short family of 3 graphs.
https://en.wikipedia.org/wiki/Chang_graphs http://www.win.tue.nl/~aeb/graphs/Chang.html
Nathann
Change History (10)
comment:1 Changed 6 years ago by
- Branch set to pubic/18785
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Branch changed from pubic/18785 to public/18785
- Commit set to 65540176492cdad3abe4de47cb11c681ee839acb
comment:3 Changed 6 years ago by
The patch is OK, but you should add the name of the method to the list of families of graphs (table at the begining of file graph_generators.py
).
comment:4 follow-up: ↓ 6 Changed 6 years ago by
My mistake, it is in the list.
However, why not using the same convention than for other graph generators, i.e., ChangGraphs
instead of chang_graphs
?
comment:5 Changed 6 years ago by
perhaps it's time for Sage to get two-graphs and Seidel (aka graph) switching. (Chang graphs are a switching class, see https://en.wikipedia.org/wiki/Two-graph).
comment:6 in reply to: ↑ 4 ; follow-up: ↓ 10 Changed 6 years ago by
Hellooooooooo,
However, why not using the same convention than for other graph generators, i.e.,
ChangGraphs
instead ofchang_graphs
?
I followed the "convention" that the code seems to follow about functions which return *several* graphs: fusenes/planar_graph/trees/triangulations/line_graph_forbidden_subgraphs/cospectral_graphs/...
. There is not a single "Graphs" but several "graphs" already.
Nathann
comment:7 Changed 6 years ago by
- Reviewers set to David Coudert
- Status changed from needs_review to positive_review
ok, so then it's good to go.
comment:8 Changed 6 years ago by
Thanks !
comment:9 Changed 6 years ago by
- Branch changed from public/18785 to 65540176492cdad3abe4de47cb11c681ee839acb
- Resolution set to fixed
- Status changed from positive_review to closed
comment:10 in reply to: ↑ 6 Changed 6 years ago by
- Commit 65540176492cdad3abe4de47cb11c681ee839acb deleted
Replying to ncohen:
Hellooooooooo,
However, why not using the same convention than for other graph generators, i.e.,
ChangGraphs
instead ofchang_graphs
?I followed the "convention" that the code seems to follow about functions which return *several* graphs:
fusenes/planar_graph/trees/triangulations/line_graph_forbidden_subgraphs/cospectral_graphs/...
. There is not a single "Graphs" but several "graphs" already.
IMHO it still must be Chang (it's a person, whereas cospectral is not!), not chang...
And, by the way, switching: #18972 - not completely done, but still :-)
New commits:
trac #18785: chang graphs