Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#18782 closed enhancement (fixed)

DejterGraph, F26AGraph, HarborthGraph, Klein3RegularGraph, Klein7RegularGraph, LocalMcLaughlinGraph

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.8
Component: graph theory Keywords:
Cc: vdelecroix, dimpase, chapoton Merged in:
Authors: Nathann Cohen Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 39cd4eb (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by ncohen)

This branch adds the following graph constructors:

DejterGraph !F26AGraph HarborthGraph !Klein3RegularGraph !Klein7RegularGraph LocalMcLaughlinGraph

Nathann

Change History (9)

comment:1 Changed 2 years ago by ncohen

  • Branch set to public/18782
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 2 years ago by git

  • Commit set to d7fb7b45508fb0ac241b0f2c91de3fd6cef15f0d

Branch pushed to git repo; I updated commit sha1. New commits:

​d7fb7b4trac #18782: DejterGraph, F26AGraph, HarborthGraph, Klein3RegularGraph, Klein7RegularGraph, LocalMcLaughlinGraph

comment:3 follow-up: Changed 2 years ago by chapoton

  • Status changed from needs_review to needs_work

missing # optional gap_packages

for the LocalMcLaughlinGraph?

comment:4 Changed 2 years ago by git

  • Commit changed from d7fb7b45508fb0ac241b0f2c91de3fd6cef15f0d to 39cd4eb0a25fad960e9a77d33091641dad579957

Branch pushed to git repo; I updated commit sha1. New commits:

​101b516trac #18782: Merged with 6.8.beta6
​39cd4ebtrac #18782: Add 'optional' tag

comment:5 in reply to: ↑ 3 Changed 2 years ago by ncohen

  • Status changed from needs_work to needs_review

missing # optional gap_packages

for the LocalMcLaughlinGraph?

Sorry. Fixed.

Nathann

comment:6 Changed 2 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

Hello,

I have tried the patch before and after installing gap_packages and it is working properly (install, doc, tests).

David.

comment:7 Changed 2 years ago by ncohen

Thaaaaaaaaaaaaaaaaaaaaaaaaaanks !!!!

Nathann

comment:8 Changed 2 years ago by vbraun

  • Branch changed from public/18782 to 39cd4eb0a25fad960e9a77d33091641dad579957
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 2 years ago by jdemeyer

  • Commit 39cd4eb0a25fad960e9a77d33091641dad579957 deleted

Breakage: #18911

Note: See TracTickets for help on using tickets.