Opened 6 years ago

Closed 5 years ago

#18781 closed enhancement (fixed)

sage-fix-pkg-chksums should allow .tgz file name endings; and perhaps .zip?

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: jdemeyer, jhpalmieri, ohanar, robertwb, vbraun, ncohen, mkoeppe Merged in:
Authors: Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges


This is so that one can use the original names of upstream tarballs. See #10879, whose upstream is called .....tgz

Also, perhaps .zip files should be supported as well by the spkg scripts, if possible. See #18708.

Change History (9)

comment:1 Changed 6 years ago by vbraun

Really it shouldn't make any assumptions on the file name; It is specified in checksum.ini + package-version.txt. Would be easy to fix with #18748

comment:2 Changed 6 years ago by ncohen

  • Cc jdemeyer ncohen added; demeyer removed

comment:3 Changed 6 years ago by jdemeyer

Certainly not .zip since sage-spkg does not support unzip, nor do we currently have an unzip package.

comment:4 Changed 6 years ago by vbraun

Python's zipfile module can easily be used to unzip

comment:5 Changed 6 years ago by ncohen

See #19484 and #19487.

comment:6 Changed 6 years ago by ncohen

  • Cc mkoeppe added

comment:7 Changed 5 years ago by mkoeppe

  • Milestone changed from sage-6.8 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

This ticket is outdated and can be closed.

comment:8 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:9 Changed 5 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.