Opened 8 years ago
Closed 8 years ago
#18772 closed enhancement (fixed)
Completely remove in-place operations
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.8 |
Component: | coercion | Keywords: | |
Cc: | ncohen | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | François Bissey |
Report Upstream: | N/A | Work issues: | |
Branch: | 1857b02 (Commits, GitHub, GitLab) | Commit: | 1857b025948ecbdf1093952832096e986deff969 |
Dependencies: | Stopgaps: |
Description (last modified by )
Change History (9)
comment:1 Changed 8 years ago by
Cc: | ncohen added |
---|
comment:2 Changed 8 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 8 years ago by
Branch: | → u/jdemeyer/completely_remove_in_place_operations |
---|
comment:4 Changed 8 years ago by
Commit: | → 1857b025948ecbdf1093952832096e986deff969 |
---|---|
Status: | new → needs_review |
New commits:
1857b02 | Completely remove in-place operations
|
comment:5 Changed 8 years ago by
Description: | modified (diff) |
---|
comment:6 Changed 8 years ago by
Reviewers: | → François Bissey |
---|---|
Status: | needs_review → positive_review |
Looks good to me.
comment:7 follow-up: 8 Changed 8 years ago by
Status: | positive_review → needs_info |
---|
I don't mind if this ticket gets put straight back to positive, but perhaps you can check:
On #624 there is mention of a special option for Cython that is required. If we're ripping the whole in-place stuff out, we can probably also get rid of this Cython option. Since that should save an incref/decref it might lead to slightly faster code. Might be worth looking at?
hm, the relevant option seems to be --incref-local-binop
, which by the looks of it was already disabled on #3331. So we're probably good. Can someone confirm?
comment:8 Changed 8 years ago by
Status: | needs_info → positive_review |
---|
comment:9 Changed 8 years ago by
Branch: | u/jdemeyer/completely_remove_in_place_operations → 1857b025948ecbdf1093952832096e986deff969 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
(being curious, though I have no idea what this ticket is about)