Opened 7 years ago

Closed 7 years ago

#18771 closed enhancement (fixed)

Clean up interface interrupt() and use it in _expect_expr()

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.8
Component: interfaces Keywords: interrupt
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 45969a6 (Commits, GitHub, GitLab) Commit: 45969a656b26452cb980c9537dcc087977811573
Dependencies: Stopgaps:

Status badges

Description


Change History (6)

comment:1 Changed 7 years ago by jdemeyer

  • Branch set to u/jdemeyer/clean_up_interface_interrupt___and_use_it_in__expect_expr__

comment:2 Changed 7 years ago by jdemeyer

  • Commit set to 45969a656b26452cb980c9537dcc087977811573
  • Status changed from new to needs_review

New commits:

45969a6Clean up interrupt()

comment:3 follow-up: Changed 7 years ago by chapoton

  • Keywords interrupt added
  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good to me, as far as I can say

Please use simpler branch names, this one was was hard to copy-paste !

comment:4 in reply to: ↑ 3 ; follow-up: Changed 7 years ago by jdemeyer

Replying to chapoton:

Please use simpler branch names, this one was was hard to copy-paste !

I never copy-paste branch names, you can use git trac checkout 18771.

comment:5 in reply to: ↑ 4 Changed 7 years ago by chapoton

Replying to jdemeyer:

Replying to chapoton:

Please use simpler branch names, this one was was hard to copy-paste !

I never copy-paste branch names, you can use git trac checkout 18771.

I never use git trac and hope that I will never have to.

comment:6 Changed 7 years ago by vbraun

  • Branch changed from u/jdemeyer/clean_up_interface_interrupt___and_use_it_in__expect_expr__ to 45969a656b26452cb980c9537dcc087977811573
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.