Opened 4 years ago

Closed 4 years ago

#18767 closed enhancement (fixed)

Integrable Representations of Twisted Affine Lie algebras

Reported by: bump Owned by:
Priority: major Milestone: sage-6.9
Component: combinatorics Keywords: Integrable Representations, Twisted Affine Lie Algebras
Cc: bump, tscrim, buciumas, sage-combinat Merged in:
Authors: Daniel Bump, Valentin Buciumas Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3966f09 (Commits) Commit: 3966f09d89f5d0c66eb6f803f1a91efd3e0bd979
Dependencies: Stopgaps:

Description (last modified by bump)

This ticket continues the support for integrable representations of affine Lie algebras by implementing the twisted affine cases. The untwisted cases were implemented in #15806 and #18398. See also #18000.

Change History (13)

comment:1 Changed 4 years ago by tscrim

  • Cc tscrim added

comment:2 Changed 4 years ago by bump

  • Authors set to Daniel Bump, Valentin Buciumas
  • Branch set to public/combinat/integrable_twisted_18767
  • Cc buciumas sage-combinat added
  • Commit set to c8782d8438084aeb0253da08245a93682ac491bd

New commits:

c8782d8seems working for type ['A',2,2l-1]

comment:3 Changed 4 years ago by bump

Valentin Buciumas has figured out what needs to be done to get the code working for the twisted affine case.

comment:4 Changed 4 years ago by bump

  • Branch changed from public/combinat/integrable_twisted_18767 to public/combinat/twisted_affine-18767
  • Commit changed from c8782d8438084aeb0253da08245a93682ac491bd to 914341e07afd70770cb8299989924bbf84e77552

New commits:

914341elast patch

comment:5 Changed 4 years ago by bump

  • Description modified (diff)
  • Status changed from new to needs_review

comment:6 Changed 4 years ago by bump

  • Milestone changed from sage-6.8 to sage-6.9

comment:7 Changed 4 years ago by bump

  • Reviewers set to Travis Scrimshaw

comment:8 Changed 4 years ago by git

  • Commit changed from 914341e07afd70770cb8299989924bbf84e77552 to 2cd19ba5eee863d7224c28fceb7db998548b904a

Branch pushed to git repo; I updated commit sha1. New commits:

2cd19baadded a test, revised comments

comment:9 Changed 4 years ago by git

  • Commit changed from 2cd19ba5eee863d7224c28fceb7db998548b904a to 513ea7bfa133b5677d75396fcd41c6a5efd133a1

Branch pushed to git repo; I updated commit sha1. New commits:

513ea7bundid accidental reversion of #18246

comment:10 Changed 4 years ago by git

  • Commit changed from 513ea7bfa133b5677d75396fcd41c6a5efd133a1 to 3966f09d89f5d0c66eb6f803f1a91efd3e0bd979

Branch pushed to git repo; I updated commit sha1. New commits:

f5dda03Merge branch 'public/combinat/twisted_affine-18767' of trac.sagemath.org:sage into public/combinat/twisted_affine-18767
e79114aFirst round of review changes.
3966f09Getting some more speed and minor refactoring to improve readability/memory.

comment:11 Changed 4 years ago by tscrim

I've done my reviewer changes, and I obtained some good speed improvements:

sage: Lambda = RootSystem(['A',5,2]).weight_lattice(extended=true).fundamental_weights()
sage: V = IntegrableRepresentation(Lambda[0]+Lambda[1]+Lambda[3])
sage: %time V.print_strings()
...
CPU times: user 3.14 s, sys: 28.5 ms, total: 3.16 s
Wall time: 3.11 s

sage: Lambda = RootSystem(['A',8,2]).weight_lattice(extended=true).fundamental_weights()
sage: V = IntegrableRepresentation(Lambda[0]+Lambda[3])
sage: %time V.print_strings()
...
CPU times: user 8.66 s, sys: 44.2 ms, total: 8.7 s
Wall time: 8.66 s

Before:

sage: Lambda = RootSystem(['A',5,2]).weight_lattice(extended=true).fundamental_weights()
sage: V = IntegrableRepresentation(Lambda[0]+Lambda[1]+Lambda[3])
sage: %time V.print_strings()
...
CPU times: user 3.6 s, sys: 35.7 ms, total: 3.64 s
Wall time: 3.57 s

sage: Lambda = RootSystem(['A',8,2]).weight_lattice(extended=true).fundamental_weights()
sage: V = IntegrableRepresentation(Lambda[0]+Lambda[3])
sage: %time V.print_strings()
...
CPU times: user 10 s, sys: 68.6 ms, total: 10.1 s
Wall time: 10 s

If you happy with my changes, then you can set a positive review.

comment:12 Changed 4 years ago by bump

  • Status changed from needs_review to positive_review

comment:13 Changed 4 years ago by vbraun

  • Branch changed from public/combinat/twisted_affine-18767 to 3966f09d89f5d0c66eb6f803f1a91efd3e0bd979
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.