Opened 6 years ago
Closed 6 years ago
#18767 closed enhancement (fixed)
Integrable Representations of Twisted Affine Lie algebras
Reported by:  bump  Owned by:  

Priority:  major  Milestone:  sage6.9 
Component:  combinatorics  Keywords:  Integrable Representations, Twisted Affine Lie Algebras 
Cc:  bump, tscrim, buciumas, sagecombinat  Merged in:  
Authors:  Daniel Bump, Valentin Buciumas  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  3966f09 (Commits, GitHub, GitLab)  Commit:  3966f09d89f5d0c66eb6f803f1a91efd3e0bd979 
Dependencies:  Stopgaps: 
Description (last modified by )
Change History (13)
comment:1 Changed 6 years ago by
 Cc tscrim added
comment:2 Changed 6 years ago by
 Branch set to public/combinat/integrable_twisted_18767
 Cc buciumas sagecombinat added
 Commit set to c8782d8438084aeb0253da08245a93682ac491bd
comment:3 Changed 6 years ago by
Valentin Buciumas has figured out what needs to be done to get the code working for the twisted affine case.
comment:4 Changed 6 years ago by
 Branch changed from public/combinat/integrable_twisted_18767 to public/combinat/twisted_affine18767
 Commit changed from c8782d8438084aeb0253da08245a93682ac491bd to 914341e07afd70770cb8299989924bbf84e77552
New commits:
914341e  last patch

comment:5 Changed 6 years ago by
 Description modified (diff)
 Status changed from new to needs_review
comment:6 Changed 6 years ago by
 Milestone changed from sage6.8 to sage6.9
comment:7 Changed 6 years ago by
 Reviewers set to Travis Scrimshaw
comment:8 Changed 6 years ago by
 Commit changed from 914341e07afd70770cb8299989924bbf84e77552 to 2cd19ba5eee863d7224c28fceb7db998548b904a
Branch pushed to git repo; I updated commit sha1. New commits:
2cd19ba  added a test, revised comments

comment:9 Changed 6 years ago by
 Commit changed from 2cd19ba5eee863d7224c28fceb7db998548b904a to 513ea7bfa133b5677d75396fcd41c6a5efd133a1
Branch pushed to git repo; I updated commit sha1. New commits:
513ea7b  undid accidental reversion of #18246

comment:10 Changed 6 years ago by
 Commit changed from 513ea7bfa133b5677d75396fcd41c6a5efd133a1 to 3966f09d89f5d0c66eb6f803f1a91efd3e0bd979
Branch pushed to git repo; I updated commit sha1. New commits:
f5dda03  Merge branch 'public/combinat/twisted_affine18767' of trac.sagemath.org:sage into public/combinat/twisted_affine18767

e79114a  First round of review changes.

3966f09  Getting some more speed and minor refactoring to improve readability/memory.

comment:11 Changed 6 years ago by
I've done my reviewer changes, and I obtained some good speed improvements:
sage: Lambda = RootSystem(['A',5,2]).weight_lattice(extended=true).fundamental_weights() sage: V = IntegrableRepresentation(Lambda[0]+Lambda[1]+Lambda[3]) sage: %time V.print_strings() ... CPU times: user 3.14 s, sys: 28.5 ms, total: 3.16 s Wall time: 3.11 s sage: Lambda = RootSystem(['A',8,2]).weight_lattice(extended=true).fundamental_weights() sage: V = IntegrableRepresentation(Lambda[0]+Lambda[3]) sage: %time V.print_strings() ... CPU times: user 8.66 s, sys: 44.2 ms, total: 8.7 s Wall time: 8.66 s
Before:
sage: Lambda = RootSystem(['A',5,2]).weight_lattice(extended=true).fundamental_weights() sage: V = IntegrableRepresentation(Lambda[0]+Lambda[1]+Lambda[3]) sage: %time V.print_strings() ... CPU times: user 3.6 s, sys: 35.7 ms, total: 3.64 s Wall time: 3.57 s sage: Lambda = RootSystem(['A',8,2]).weight_lattice(extended=true).fundamental_weights() sage: V = IntegrableRepresentation(Lambda[0]+Lambda[3]) sage: %time V.print_strings() ... CPU times: user 10 s, sys: 68.6 ms, total: 10.1 s Wall time: 10 s
If you happy with my changes, then you can set a positive review.
comment:12 Changed 6 years ago by
 Status changed from needs_review to positive_review
comment:13 Changed 6 years ago by
 Branch changed from public/combinat/twisted_affine18767 to 3966f09d89f5d0c66eb6f803f1a91efd3e0bd979
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
seems working for type ['A',2,2l1]