Opened 4 years ago

Closed 4 years ago

#18747 closed enhancement (fixed)

ascii and unicode arts for continued fractions

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-6.8
Component: basic arithmetic Keywords:
Cc: tmonteil, vbraun Merged in:
Authors: Vincent Delecroix Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6e4744a (Commits) Commit: 6e4744af8e835f3055030ac486db8b17366ccd92
Dependencies: Stopgaps:

Description

sage: unicode_art(continued_fraction(pi))
                             1                          
3 + ────────────────────────────────────────────────────
                                1                       
     7 + ───────────────────────────────────────────────
                                   1                    
          15 + ─────────────────────────────────────────
                                     1                  
                1 + ────────────────────────────────────
                                         1              
                     292 + ─────────────────────────────
                                           1            
                            1 + ────────────────────────
                                              1         
                                 1 + ───────────────────
                                                1       
                                      1 + ──────────────
                                                   1    
                                           2 + ─────────
                                                1 + ... 

Change History (5)

comment:1 Changed 4 years ago by vdelecroix

  • Branch set to u/vdelecroix/18747
  • Commit set to c327971ff0b6c7edc684e26eeb49f22528d3cf67
  • Status changed from new to needs_review

New commits:

c327971Trac #18747: ascii art for continued fractions

comment:2 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

LGTM modulo making the input - ``x`` -- with two dashes as that is the Sage convention. Once you make this tweak, positive review. Thanks.

comment:3 Changed 4 years ago by git

  • Commit changed from c327971ff0b6c7edc684e26eeb49f22528d3cf67 to 6e4744af8e835f3055030ac486db8b17366ccd92

Branch pushed to git repo; I updated commit sha1. New commits:

6e4744aTrac #18747: two dashes

comment:4 Changed 4 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/vdelecroix/18747 to 6e4744af8e835f3055030ac486db8b17366ccd92
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.