Opened 7 years ago
Closed 7 years ago
#18736 closed defect (fixed)
Fix deprecation in conway_polynomials spkg-install
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.8 |
Component: | packages: standard | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | François Bissey |
Report Upstream: | N/A | Work issues: | |
Branch: | 0f95091 (Commits, GitHub, GitLab) | Commit: | 0f9509164b38b8febba257c994bf7abeeac50727 |
Dependencies: | Stopgaps: |
Description
When installing conway_polynomials
:
./spkg-install:7: DeprecationWarning: Importing SAGE_SHARE from here is deprecated. If you need to use it, please import it directly from sage.env See http://trac.sagemath.org/17460 for details. install_root = os.path.join(SAGE_SHARE, 'conway_polynomials')
Change History (8)
comment:1 Changed 7 years ago by
- Branch set to u/jdemeyer/fix_deprecation_in_conway_polynomials_spkg_install
comment:2 Changed 7 years ago by
- Commit set to 0f9509164b38b8febba257c994bf7abeeac50727
- Status changed from new to needs_review
comment:3 follow-up: ↓ 4 Changed 7 years ago by
Yes I remember noticing that when there was that problem with conway_polynomials
on sage-devel. Before putting this to positive review because it is trivial, what would you say about making it independent of SAGE_RUNTIME
?
https://github.com/cschwan/sage-on-gentoo/blob/master/sci-mathematics/sage-data-conway_polynomials/files/spkg-install
comment:4 in reply to: ↑ 3 Changed 7 years ago by
Replying to fbissey:
what would you say about making it independent of
SAGE_RUNTIME
?
What's the advantage of doing that?
comment:5 follow-up: ↓ 6 Changed 7 years ago by
- Reviewers set to François Bissey
- Status changed from needs_review to positive_review
The only immediate payload is that sage doesn't need to be installed to then install conway_polynomial
, which has always bothered me because sage itself won't start if conway_polynomial
is not installed. Of course sage is never started for the installation.
Thinking further ahead, I did this in sage-on-gentoo because it will enable me to install all the runtime dependencies of sage before sage itself. In turn, thanks to that, I may be able to run the testsuite before installing sage like most other software packages.
But we do not to do this here.
comment:6 in reply to: ↑ 5 ; follow-up: ↓ 7 Changed 7 years ago by
Replying to fbissey:
sage itself won't start if
conway_polynomial
is not installed.
That's false. Sage can start even if conway_polynomials
is not installed. Of course, not all doctests will pass.
I may be able to run the testsuite before installing sage like most other software packages.
I understand.
comment:7 in reply to: ↑ 6 Changed 7 years ago by
comment:8 Changed 7 years ago by
- Branch changed from u/jdemeyer/fix_deprecation_in_conway_polynomials_spkg_install to 0f9509164b38b8febba257c994bf7abeeac50727
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Minor fixes to spkg-install of conway_polynomials