Opened 6 years ago

Closed 6 years ago

#18728 closed defect (fixed)

PARI nfisisom() should convert its argument

Reported by: pbruin Owned by:
Priority: minor Milestone: sage-6.8
Component: interfaces Keywords: pari gen
Cc: Merged in:
Authors: Peter Bruin Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: e20d549 (Commits, GitHub, GitLab) Commit: e20d549cde442240ae130e29c99f7e2c1e8b5585
Dependencies: Stopgaps:

Status badges

Description

The method sage.libs.pari.gen.gen.nfisisom() has an argument that is declared as gen; it would be more useful if it would convert its argument using objtogen().

Example:

sage: K.<a> = NumberField(x^2 + x + 1)
sage: L.<b> = NumberField(x^2 + 3)
sage: pari(K).nfisisom(L)
Traceback (most recent call last):
...
TypeError: Argument 'other' has incorrect type (expected sage.libs.pari.gen.gen, got NumberField_quadratic_with_category)

Change History (3)

comment:1 Changed 6 years ago by pbruin

  • Branch set to u/pbruin/18728-nfisisom
  • Commit set to e20d549cde442240ae130e29c99f7e2c1e8b5585
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:3 Changed 6 years ago by vbraun

  • Branch changed from u/pbruin/18728-nfisisom to e20d549cde442240ae130e29c99f7e2c1e8b5585
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.