Opened 5 years ago

Closed 5 years ago

#18727 closed enhancement (fixed)

Clean up number_field/maps.py

Reported by: pbruin Owned by:
Priority: minor Milestone: sage-6.8
Component: number fields Keywords:
Cc: Merged in:
Authors: Peter Bruin Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 195d3d2 (Commits) Commit: 195d3d277264283a315b3438e35c22ed68f78a08
Dependencies: Stopgaps:

Description

The goal of this ticket is to clean up of the code in sage/rings/number_field/maps.py, which contains several unnecessary attributes and conversions. One motivation for this is to simplify work on #252.

There are no changes in functionality. The total running time of the doctests in sage/rings/number_field does not increase and even appears to decrease slightly.

Change History (3)

comment:1 Changed 5 years ago by pbruin

  • Branch set to u/pbruin/18727-number_field_maps_cleanup
  • Commit set to 195d3d277264283a315b3438e35c22ed68f78a08
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review
  • Type changed from task to enhancement

It is possibly a bit faster because the cython function calls are faster than the python attribute calls? Anyways, LGTM.

comment:3 Changed 5 years ago by vbraun

  • Branch changed from u/pbruin/18727-number_field_maps_cleanup to 195d3d277264283a315b3438e35c22ed68f78a08
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.