Opened 2 years ago

Closed 2 years ago

#18726 closed enhancement (fixed)

Do not import IPython at startup

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.8
Component: performance Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 3f2192a (Commits) Commit: 3f2192a8f9ddbbaa8de7f4ea0ed82053457914b3
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Just a few changes to do this.

This patch also removes the broken functions log_html, log_dvi, log_text from the global namespace (no point in deprecating them if they don't work)

Change History (6)

comment:1 Changed 2 years ago by jdemeyer

  • Component changed from misc to performance
  • Description modified (diff)
  • Summary changed from Remove load_ipython_extension() to Do not import IPython at startup

comment:2 Changed 2 years ago by jdemeyer

  • Branch set to u/jdemeyer/remove_load_ipython_extension__

comment:3 Changed 2 years ago by jdemeyer

  • Commit set to 3f2192a8f9ddbbaa8de7f4ea0ed82053457914b3
  • Status changed from new to needs_review

New commits:

3f2192aDo not load IPython at startup

comment:4 Changed 2 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 2 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

This looks good, IPython is not loaded at startup, and all tests pass.

comment:6 Changed 2 years ago by vbraun

  • Branch changed from u/jdemeyer/remove_load_ipython_extension__ to 3f2192a8f9ddbbaa8de7f4ea0ed82053457914b3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.