Opened 6 years ago
Closed 6 years ago
#18701 closed enhancement (fixed)
Add codim() method for convex cones
Reported by:  mjo  Owned by:  

Priority:  major  Milestone:  sage6.8 
Component:  geometry  Keywords:  
Cc:  Merged in:  
Authors:  Michael Orlitzky  Reviewers:  Andrey Novoseltsev 
Report Upstream:  N/A  Work issues:  
Branch:  0fdb077 (Commits, GitHub, GitLab)  Commit:  0fdb077f83d409b1db7f4133e69394023eb66ba3 
Dependencies:  #18696  Stopgaps: 
Description
The dimension of a cone is defined to be the dimension of the span of its generators. It then makes sense to define the codimension as the dimension of the orthogonal complement of that span. This number is equal to the lineality (see trac #18696) of the dual cone.
Change History (12)
comment:1 Changed 6 years ago by
 Branch set to u/mjo/ticket/18701
 Commit set to 2d1a511049c6afdb98fb59b5b765ad41b6bb7468
 Status changed from new to needs_review
comment:2 Changed 6 years ago by
 Commit changed from 2d1a511049c6afdb98fb59b5b765ad41b6bb7468 to d67300023d9a67a1857c5e634b52746d009d1622
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
d673000  Trac #18701: Add a codim() method for convex cones.

comment:3 Changed 6 years ago by
That forcepush moved the method into the IntegralRayCollection
superclass, where I believe it belongs.
comment:4 Changed 6 years ago by
 Commit changed from d67300023d9a67a1857c5e634b52746d009d1622 to 1bb89361c36344624532a41861941fac1e39cb96
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
deeb2ec  Trac #18454: Allow random_cone() to be (non)strictlyconvex.

44ac645  Trac #18454: Remove an unnecessary exception in random_cone().

909997a  Trac #18454: Set max_dim on a random_cone() test that could run forever.

bd24822  Trac #18454: Add a "solid" parameter to random_cone().

ba66027  Trac #18454: Fix warning block formatting in random_cone().

8b2ff99  Trac #18454: Catch another infinite loop condition.

78c206f  Trac #18454: Call set_random_seed() before all random doctests.

7bdaf1c  Trac #18454: Speed up random_cone() doctests.

473de25  Trac #18696: Add lineality() method for convex cones.

1bb8936  Trac #18701: Add a codim() method for convex cones.

comment:5 Changed 6 years ago by
Testing the new trac server's ability to send email...
comment:6 Changed 6 years ago by
 Commit changed from 1bb89361c36344624532a41861941fac1e39cb96 to 1307fb6bd7d5218f3a1736c04eef372ab47fe6ce
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
52a1e4b  Trac #18454: Rename min/max_dim to min/max_ambient_dim in random_cone().

a0235dc  Trac #18454: Fix two confusing random_cone() examples.

5b1eccb  Trac #18454: Remove some excessive doctests for random_cone().

5bf86a6  Trac #18454: Clean up long random_cone() tests.

3e9fd77  Trac #18696: Add lineality() method for convex cones.

1307fb6  Trac #18701: Add a codim() method for convex cones.

comment:7 Changed 6 years ago by
 Commit changed from 1307fb6bd7d5218f3a1736c04eef372ab47fe6ce to 4dbe641ae5c78e3adf996bb4c0a9b000098321dc
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
e6e7a80  Merge branch 't/18613/errors_with_is_isomorphic___for_trivial_cones' into t/18454/ticket/18454

a07efa9  Reviewer's tweaks to random cones.

8c962e1  Trac #18454: Remove more redundant (long) tests.

ed422e3  Trac #18696: Add lineality() method for convex cones.

4dbe641  Trac #18701: Add a codim() method for convex cones.

comment:8 Changed 6 years ago by
 Reviewers set to Andrey Novoseltsev
Same comments as for #18696 and:
 I'd prefer using "self" to "this collection of rays" in the documentation. That class seemed natural to me as a base of both cones and rays, yet by itself it seems not particularly useful and all doctest examples actually rely on cones. So I think users of
cone.codim?
will be confused by the mention of a ray collection. If you prefer to avoid "self", perhaps "cone/fan" combination can be used instead?
comment:9 Changed 6 years ago by
 Commit changed from 4dbe641ae5c78e3adf996bb4c0a9b000098321dc to 0fdb077f83d409b1db7f4133e69394023eb66ba3
comment:10 Changed 6 years ago by
Thanks again for your help with these. I had to forcepush that last one, not sure why.
comment:11 Changed 6 years ago by
 Status changed from needs_review to positive_review
Because you had a commit from the previous ticket here: when you rebased on top of it, the current branch here had commits that are now thrown away.
comment:12 Changed 6 years ago by
 Branch changed from u/mjo/ticket/18701 to 0fdb077f83d409b1db7f4133e69394023eb66ba3
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
Trac #18454: Allow random_cone() to be (non)strictlyconvex.
Trac #18454: Remove an unnecessary exception in random_cone().
Trac #18454: Set max_dim on a random_cone() test that could run forever.
Trac #18454: Add a "solid" parameter to random_cone().
Trac #18454: Fix warning block formatting in random_cone().
Trac #18454: Catch another infinite loop condition.
Trac #18454: Call set_random_seed() before all random doctests.
Trac #18454: Speed up random_cone() doctests.
Trac #18696: Add lineality() method for convex cones.
Trac #18701: Add a codim() method for convex cones.