Changes between Version 3 and Version 5 of Ticket #18697


Ignore:
Timestamp:
07/01/15 14:44:27 (6 years ago)
Author:
rws
Comment:

Partial "fix" of Sage code removed, it was actually an unrelated Pynac issue, which is fixed in 0.4.2.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18697

    • Property Report Upstream changed from Reported upstream. Developers acknowledge bug. to N/A
  • Ticket #18697 – Description

    v3 v5  
    66
    77https://github.com/pynac/pynac/issues/71
    8 
    9 The Pynac issue will need this fix(!) to work:
    10 {{{
    11 diff --git a/src/sage/symbolic/pynac.pyx b/src/sage/symbolic/pynac.pyx
    12 --- a/src/sage/symbolic/pynac.pyx
    13 +++ b/src/sage/symbolic/pynac.pyx
    14 @@ -2036,10 +2041,10 @@ cdef public GConstant py_get_constant(const_char_ptr name) except +:
    15          pc = c._pynac
    16          return pc.object
    17  
    18 -cdef public object py_eval_constant(unsigned serial, object kwds) except +:
    19 +cdef public object py_eval_constant(unsigned serial, object parent) except +:
    20      from sage.symbolic.constants import constants_table
    21      constant = constants_table[serial]
    22 -    return kwds['parent'](constant)
    23 +    return parent(constant)
    24 }}}