Opened 4 years ago

Closed 4 years ago

#18690 closed enhancement (fixed)

Improvement in IncidenceStructure.is_connected()

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.8
Component: combinatorial designs Keywords:
Cc: Rudi, vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: a90cb95 (Commits) Commit: a90cb95e2940f51fd57ba2e36d1cabc15ee05894
Dependencies: Stopgaps:

Description

Triggered by the discussion at #18682. Still way slower than its SetSystem counterpart, though.

Nathann

Change History (6)

comment:1 Changed 4 years ago by ncohen

  • Branch set to public/18690
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by git

  • Commit set to bc02bbae54d859d043d79fe7f465762c9b97c551

Branch pushed to git repo; I updated commit sha1. New commits:

bc02bbatrac #18690: Improvement in IncidenceStructure.is_connected()

comment:3 Changed 4 years ago by git

  • Commit changed from bc02bbae54d859d043d79fe7f465762c9b97c551 to a90cb95e2940f51fd57ba2e36d1cabc15ee05894

Branch pushed to git repo; I updated commit sha1. New commits:

a90cb95Trac #18690: DisjointSets.union a bit cleaner

comment:4 Changed 4 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix

Hi,

Does not make it really faster. But at least it is cleaner.

I am ok with your change. What do you think of mine?

Vincent

comment:5 Changed 4 years ago by ncohen

  • Status changed from needs_review to positive_review

Yep yep, looks good ;-)

Nathann

comment:6 Changed 4 years ago by vbraun

  • Branch changed from public/18690 to a90cb95e2940f51fd57ba2e36d1cabc15ee05894
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.