Opened 6 years ago

Closed 4 years ago

#18680 closed enhancement (fixed)

Implement Q-systems

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-7.6
Component: combinatorics Keywords: Q-systems, Q-system, days78, days82
Cc: gmoose05, egunawan, vichitk1 Merged in:
Authors: Travis Scrimshaw Reviewers: Emily Gunawan
Report Upstream: N/A Work issues:
Branch: 52aa146 (Commits) Commit: 52aa1467a8cc388096a59f7152412c25cc941e0d
Dependencies: Stopgaps:

Description (last modified by tscrim)

We implement Q-systems for Cartan types expressed in terms of fundamental monomials (i.e., using the variables Q1(a), where a ranges over the index set).

Change History (24)

comment:1 Changed 6 years ago by tscrim

FYI (mostly for my own record keeping) - There's also a very prelimiary branch for T-systems on the branch u/tscrim/t_systems.

Currently this is almost ready, just needs some documentation and a few other doctests.

comment:2 Changed 6 years ago by vichitk1

  • Cc vichitk1 added

comment:3 Changed 6 years ago by git

  • Commit changed from 9deac35e4ef1469c4d461a750f8261e416914716 to 307f5353427bd9d78c555106b7ea6e3c3c6d1dae

Branch pushed to git repo; I updated commit sha1. New commits:

47d0f44Added full coverage and starting to write documentation.
d5d2a1dMerge branch 'develop' into u/tscrim/q_systems
307f535Removing square-free basis because it wasn't a basis.

comment:4 Changed 6 years ago by tscrim

  • Description modified (diff)
  • Status changed from new to needs_review

comment:5 Changed 5 years ago by git

  • Commit changed from 307f5353427bd9d78c555106b7ea6e3c3c6d1dae to 321df12358a7d4bb3015347b3a19872e4a183929

Branch pushed to git repo; I updated commit sha1. New commits:

3e03bbbMerge branch 'u/tscrim/q_systems' of trac.sagemath.org:sage into u/tscrim/q_systems
321df12Fixes and updates from changes in Sage.

comment:6 Changed 5 years ago by git

  • Commit changed from 321df12358a7d4bb3015347b3a19872e4a183929 to 21e4b91ea866aa50c1a3e9f709e31d6118881299

Branch pushed to git repo; I updated commit sha1. New commits:

21e4b91Merge branch 'u/tscrim/q_systems' of trac.sagemath.org:sage into u/tscrim/q_systems

comment:7 Changed 5 years ago by egunawan

  • Branch changed from u/tscrim/q_systems to u/egunawan/q_systems
  • Commit changed from 21e4b91ea866aa50c1a3e9f709e31d6118881299 to c7b145dd0108559b88735a7fb107392ffb259815

New commits:

c7b145dMerge branch 'u/tscrim/q_systems' too Sage 7.3beta5

comment:8 follow-up: Changed 5 years ago by egunawan

Question: There are QSystem.algebra_generators() and QSystem.gen(a, m) - Do you want QSystem.gens() to work as well?

comment:9 Changed 5 years ago by egunawan

  • Status changed from needs_review to needs_info

comment:10 in reply to: ↑ 8 Changed 5 years ago by tscrim

  • Status changed from needs_info to needs_review

Replying to egunawan:

Question: There are QSystem.algebra_generators() and QSystem.gen(a, m) - Do you want QSystem.gens() to work as well?

No because gens() should return a tuple and there are an infinite number of generators (tuples must be finite).

comment:11 Changed 5 years ago by tscrim

  • Branch changed from u/egunawan/q_systems to u/tscrim/q_systems
  • Commit changed from c7b145dd0108559b88735a7fb107392ffb259815 to fc9e555b9ecd6af6617d764e103f5fe068fa6f5e
  • Keywords days78 added
  • Milestone changed from sage-6.8 to sage-7.3

Actually, from looking over my code, I was generating it by Q(a)1, which is a finite (and ordered) set. So I decided to change the method gen to Q as to not conflict with other parts of Sage and with the algebra_generators() method, although I'm not 100% sold that this should be the method name.


New commits:

fc9e555Doing some small doc changes, adding gens(), and changing gen() -> Q().

comment:12 Changed 5 years ago by git

  • Commit changed from fc9e555b9ecd6af6617d764e103f5fe068fa6f5e to f0d636c123fc4c60270cb891f01ef322b53f4f50

Branch pushed to git repo; I updated commit sha1. New commits:

7f5e161Merge branch 'u/tscrim/q_systems' of trac.sagemath.org:sage into u/tscrim/q_systems
f0d636cAdded ascii and unicode art to Q-systems.

comment:13 Changed 5 years ago by egunawan

  • Branch changed from u/tscrim/q_systems to u/egunawan/q_systems
  • Commit changed from f0d636c123fc4c60270cb891f01ef322b53f4f50 to 0645cc310bb0f7ff62e9648a4a3d78e2f1f985c7

(review still in process)


New commits:

0645cc318680: make latex look nicer. change title of reference, removed the

comment:14 Changed 4 years ago by tscrim

  • Branch changed from u/egunawan/q_systems to u/tscrim/q_systems
  • Commit changed from 0645cc310bb0f7ff62e9648a4a3d78e2f1f985c7 to 3fb757ca42c31132b47b43e858a7330bdbff0208
  • Milestone changed from sage-7.3 to sage-7.5

Rebased.


New commits:

3fb757cMerge branch 'u/egunawan/q_systems' of git://trac.sagemath.org/sage into u/tscrim/q_systems

comment:15 Changed 4 years ago by egunawan

Is the following something that is automatically included in the doc because of CombinatorialFreeModuleElement

Create a combinatorial module element. This should never be called directly, but only through the parent combinatorial free module’s __call__() method.

comment:16 Changed 4 years ago by egunawan

Did you want to add more lines in __classcall__ where you wrote: # TODO: Check for tamely laced!!!?

comment:17 Changed 4 years ago by egunawan

  • Branch changed from u/tscrim/q_systems to u/egunawan/q_systems
  • Commit changed from 3fb757ca42c31132b47b43e858a7330bdbff0208 to 502078f9992f10543c7d9e21e09f615bf1c9ed78
  • Keywords Q-system days82 added

New commits:

502078fSageMath version 7.5.rc3, Release Date: 2017-01-08 Merge branch 'u/tscrim/q_systems' of trac.sagemath.org:sage into 18680_u/tscrim/q_systems

comment:18 follow-up: Changed 4 years ago by tscrim

  • Branch changed from u/egunawan/q_systems to u/tscrim/q_systems
  • Commit changed from 502078f9992f10543c7d9e21e09f615bf1c9ed78 to 6045edda8f57ec60816417ceffe1370614e91421

I added a check for tamely-laced, moved the references to the master ref file, and added a short docstring to take care of the autogenerated stuff that comes from inheritance (comment:15).


New commits:

8ee3548Merge branch 'u/tscrim/q_systems' of git://trac.sagemath.org/sage into u/tscrim/q_systems
6045eddAdded check for tamely-laced and moved the referenced to the master file.

comment:19 in reply to: ↑ 18 Changed 4 years ago by egunawan

  • Branch changed from u/tscrim/q_systems to u/egunawan/18680
  • Commit changed from 6045edda8f57ec60816417ceffe1370614e91421 to b5a9f3ecdd643a70899c590873e26b2afff99f1f

Do you want to keep that TODO note for yourself for after you implement T-systems?


New commits:

b5a9f3efix conflicts with 7.6 beta 1

comment:20 Changed 4 years ago by egunawan

  • Reviewers set to Emily Gunawan

Travis, Could you explain the small letters you use in _unicode_art_term() for my benefit?

I've only done minimal reviewing for this ticket. If people are OK with that, you can set this to positive review.

comment:21 Changed 4 years ago by egunawan

This line

.. [KNS2011] Atsuo Kuniba and Tomoki Nakanishi and Junji Suzuki,
             `T`*-systems and* `Y`*-systems in integrable systems*.
             J. Phys. A, **44** (2011), no. 10.

seems to cause the following error:

[dochtml] OSError: [reference] /Users/eg/ALL_sage/sage17Jan2/src/doc/en/reference/references/index.rst:927: WARNING: Inline interpreted text or phrase reference start-string without end-string.

comment:22 Changed 4 years ago by tscrim

  • Branch changed from u/egunawan/18680 to u/tscrim/q_systems
  • Commit changed from b5a9f3ecdd643a70899c590873e26b2afff99f1f to 52aa1467a8cc388096a59f7152412c25cc941e0d
  • Milestone changed from sage-7.5 to sage-7.6

I fixed the documentations issue(s) and removed the comment since I don't plan on implementing T-systems in the near future. I also tweaked the unicode output slightly to make it more readable. In fact, those small upper/lower numbers are the super/subscript numbers for the unicode output. If these changes are good with you, then you can set a positive review.


New commits:

52aa146Fixing the docbuild, removing todo comment, and some the unicode output format.

comment:23 Changed 4 years ago by egunawan

  • Status changed from needs_review to positive_review

comment:24 Changed 4 years ago by vbraun

  • Branch changed from u/tscrim/q_systems to 52aa1467a8cc388096a59f7152412c25cc941e0d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.