Opened 5 years ago

Closed 5 years ago

#18667 closed enhancement (fixed)

Remove support for make build-serial

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-6.8
Component: build Keywords:
Cc: ncohen Merged in:
Authors: Jeroen Demeyer Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: e3897ed (Commits) Commit: e3897ed2c1403f533bc4bb5c28b3f19dd0aa5c25
Dependencies: Stopgaps:

Description (last modified by ncohen)

Nobody uses [1]

make build-serial

(what's the point anyway?)

It only clutters Makefile, so let's remove it.

Eventually I would like to move more of Makefile into build/Makefile and this ticket will make this easier.

[1] https://groups.google.com/d/topic/sage-devel/k9KbXx4dTVY/discussion

Change History (12)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/remove_support_for_make_build_serial

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to 28dd841ad3fb792b1a8e2e336490f172c03a861f
  • Status changed from new to needs_review

New commits:

28dd841Remove support for "make build-serial"

comment:3 Changed 5 years ago by ncohen

  • Cc ncohen added

comment:4 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 5 years ago by ncohen

  • Description modified (diff)

comment:6 follow-up: Changed 5 years ago by ncohen

Just to make sure: you want to remove this build rule, but you don't want to remove support for the SAGE_PARALLEL_BUILD_SPKG environment variable?

comment:7 in reply to: ↑ 6 Changed 5 years ago by jdemeyer

Replying to ncohen:

Just to make sure: you want to remove this build rule, but you don't want to remove support for the SAGE_PARALLEL_BUILD_SPKG environment variable?

Yes. I don't care much about the environment variable, it doesn't bother me.

comment:8 Changed 5 years ago by ncohen

What would you think of removing both? If the grounds for removing that rule are that it is useless, why wouldn't we get rid of the variable (and its documentation) at the same time?

Nathann

comment:9 Changed 5 years ago by git

  • Commit changed from 28dd841ad3fb792b1a8e2e336490f172c03a861f to e3897ed2c1403f533bc4bb5c28b3f19dd0aa5c25

Branch pushed to git repo; I updated commit sha1. New commits:

e3897edRemove env variables SAGE_PARALLEL_SPKG_BUILD and SAGE_SPKG_LIST_FILES

comment:10 Changed 5 years ago by jdemeyer

OK. I checked all environment variables and noticed that SAGE_SPKG_LIST_FILES is also completely pointless, so I'm removing that also.

comment:11 Changed 5 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Goooooooood to go. And I had no idea that you could set default values for variables in bash, i.e. ${my_variable:-3} :-P

Nathann

comment:12 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/remove_support_for_make_build_serial to e3897ed2c1403f533bc4bb5c28b3f19dd0aa5c25
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.