Opened 4 years ago

Closed 4 years ago

#18666 closed defect (fixed)

Add pexpect to SAGERUNTIME

Reported by: ncohen Owned by:
Priority: blocker Milestone: sage-6.8
Component: build Keywords:
Cc: vbraun, jdemeyer Merged in:
Authors: Nathann Cohen Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 3058171 (Commits) Commit: 3058171028c52af6d813cfe01c2c2875a72f56fa
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

As reported in sage-devel [1], pexpect should be a dependency of SAGERUNTIME. In #18508, this dependency was accidentally removed.

With this branch, the dependency is made explicit.

Nathann

[1] ​https://groups.google.com/d/msg/sage-devel/l8rxJjrNWk8/UKX33cqae34J

Change History (7)

comment:1 Changed 4 years ago by ncohen

  • Branch set to public/18666
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by git

  • Commit set to 3058171028c52af6d813cfe01c2c2875a72f56fa

Branch pushed to git repo; I updated commit sha1. New commits:

​3058171trac #18666: Add pexpect to SAGERUNTIME

comment:3 Changed 4 years ago by jdemeyer

  • Priority changed from major to blocker
  • Reviewers set to Jeroen Demeyer

comment:4 Changed 4 years ago by ncohen

Mystery solved: that happens in #18508, which removed sagenb as a dependency of Sage. That's how pexpect, a dependency of sagenb, was removed as a dependency from SAGERUNTIME.

Nathann

Version 0, edited 4 years ago by ncohen (next)

comment:5 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:6 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 4 years ago by vbraun

  • Branch changed from public/18666 to 3058171028c52af6d813cfe01c2c2875a72f56fa
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.