Opened 14 years ago
Closed 10 years ago
#1866 closed defect (invalid)
[probably fixed] bug in doctesting -- long time not respected in some contexts
Reported by: | was | Owned by: | failure |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | doctest coverage | Keywords: | |
Cc: | mjo | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
On Jan 20, 2008 7:28 AM, Lars Fischer <> wrote: > > Hello, > > I think I have found a bug: > chapter 2.4.1 of the Programming guide states, that comments like "# > long time (!)" prevents the example from being tested. Yep, that is a bug. I've made it. > > But: > sage -t quadratic-modules.sage > sage -t quadratic-modules.sage > Example 13 (line 433) > TIMEOUT!! > IN: > phi.level() > phi = fqmodule([11,33]); > phi.tau_invariant() > phi = fqmodule([11,33]); # long time (!) > phi.sigma_invariant() # long time (!) > OUT: > > > This applies to sage 2.10. > > I think the reason is: > sage -t calls > sage-sage and then > sage-test, which in turns calls > sage-doctest_tex, if extension is ".sage" instead of sage-doctest. > > At least sage-doctest looks for "long time" inside comment_modifiers() > and sage-doctest_tex doesnot. > > With best regards, > Lars Fischer
My first thought on reading the above is "get rid of handling .sage files in a special way in order to automatically fix all such issues". That's what I did with .tex files a while ago.
Change History (3)
comment:1 Changed 13 years ago by
- Summary changed from bug in doctesting -- long time not respected in some contexts to [probably fixed] bug in doctesting -- long time not respected in some contexts
comment:2 Changed 10 years ago by
- Cc mjo added
- Report Upstream set to N/A
- Status changed from new to needs_review
This is fixed. A simple test case:
$ cat sage_extension_tests.sage r""" A test case for *.sage files. :: sage: 1 1 :: sage: 2 # long time 2 :: sage: 3 3 """
I see that the long test is skipped normally:
$ sage -t -verbose sage_extension_tests.sage ... 5 passed and 0 failed.
And executed when -long is passed:
$ sage -t -verbose -long sage_extension_tests.sage ... 6 passed and 0 failed.
comment:3 Changed 10 years ago by
- Milestone changed from sage-4.8 to sage-duplicate/invalid/wontfix
- Resolution set to invalid
- Status changed from needs_review to closed
Note: See
TracTickets for help on using
tickets.
I think the issue has been fixed in Sage 3.2.x since we no longer treat .sage files special. Can you verify this?
Cheers,
Michael