Opened 12 years ago

Closed 12 years ago

#1864 closed defect (fixed)

[with patch; positive review] simple notebook bug -- typing ? in a comment yields introspection but shouldn't (easy to fix in worksheet.py, probably)

Reported by: was Owned by: boothby
Priority: major Milestone: sage-3.0.2
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Try this in the notebook

# This is a question?

and hit shift enter. You get introspection on the word "question".

Attachments (1)

sage-1864.patch (1.2 KB) - added by was 12 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by boothby

  • Milestone changed from sage-2.11 to sage-2.10.4

I can't reproduce this in Firefox or Opera -- has it been fixed?

comment:2 Changed 12 years ago by was

This is easy to reproduce in firefox and has not been fixed. See this screenshot:

http://sage.math.washington.edu/home/was/tmp/screenshot-comment.png

Changed 12 years ago by was

comment:3 Changed 12 years ago by was

  • Summary changed from simple notebook bug -- typing ? in a comment yields introspection but shouldn't (easy to fix in worksheet.py, probably) to [with patch; needs review] simple notebook bug -- typing ? in a comment yields introspection but shouldn't (easy to fix in worksheet.py, probably)

comment:4 Changed 12 years ago by boothby

  • Summary changed from [with patch; needs review] simple notebook bug -- typing ? in a comment yields introspection but shouldn't (easy to fix in worksheet.py, probably) to [with patch; positive review pending commentary] simple notebook bug -- typing ? in a comment yields introspection but shouldn't (easy to fix in worksheet.py, probably)

This breaks previously supported functionality (that I won't miss). It used to be, one could type

foo?

and press shift-enter to introspect. I give this a positive review *if* that was an intended change.

comment:5 Changed 12 years ago by was

  • Summary changed from [with patch; positive review pending commentary] simple notebook bug -- typing ? in a comment yields introspection but shouldn't (easy to fix in worksheet.py, probably) to [with patch; needs review] simple notebook bug -- typing ? in a comment yields introspection but shouldn't (easy to fix in worksheet.py, probably)

The referee claims that say

log?[shift-enter]

doesn't work.

However it *does* work fine with this patch. The referee needs to try again.

comment:6 Changed 12 years ago by boothby

  • Summary changed from [with patch; needs review] simple notebook bug -- typing ? in a comment yields introspection but shouldn't (easy to fix in worksheet.py, probably) to [with patch; positive review] simple notebook bug -- typing ? in a comment yields introspection but shouldn't (easy to fix in worksheet.py, probably)

Weird. Works now.

comment:7 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.2.alpha1

Note: See TracTickets for help on using tickets.