Opened 4 years ago

Closed 4 years ago

#18629 closed enhancement (fixed)

Update locations for intersphinx mapping

Reported by: aapitzsch Owned by:
Priority: major Milestone: sage-6.8
Component: documentation Keywords:
Cc: Merged in:
Authors: André Apitzsch Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 15e701d (Commits) Commit: 15e701ddcd7ff2355a2a6bc81606fb75a9e9ee95
Dependencies: Stopgaps:

Description (last modified by aapitzsch)

A lot of sites moved permanently from http to https. Updates these links in the Sagemath documentation.

Change History (7)

comment:1 Changed 4 years ago by aapitzsch

  • Branch set to u/aapitzsch/ticket/18629
  • Commit set to a16498e7fee42a68f23a54be1bcdcb85527c8eed
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by chapoton

  • Description modified (diff)
  • Status changed from needs_review to needs_work

comment:3 follow-up: Changed 4 years ago by chapoton

  • Description modified (diff)

two failing doctests, see patchbot report

why do you switch to https ?

What is the whole purpose of this ticket, by the way ?

comment:4 Changed 4 years ago by git

  • Commit changed from a16498e7fee42a68f23a54be1bcdcb85527c8eed to 15e701ddcd7ff2355a2a6bc81606fb75a9e9ee95

Branch pushed to git repo; I updated commit sha1. New commits:

78605e5Merge remote-tracking branch 'origin/develop' into python_inv
15e701dfix doctests

comment:5 in reply to: ↑ 3 Changed 4 years ago by aapitzsch

  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Summary changed from Update python.inv to Update locations for intersphinx mapping

Replying to chapoton:

two failing doctests, see patchbot report

Fixed.

why do you switch to https ?

Opening the pages via http returns 301 Moved Permanently. That's why I thought we could call the new location directly.

comment:6 Changed 4 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good to me, as far as I can tell.

patchbot is happy, so positive review.

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/aapitzsch/ticket/18629 to 15e701ddcd7ff2355a2a6bc81606fb75a9e9ee95
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.