Opened 8 years ago
Closed 7 years ago
#18588 closed enhancement (fixed)
Add d-vectors
Reported by: | etn40ff | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | combinatorics | Keywords: | Cluster Algebras, SageDays 64.5 |
Cc: | stumpc5, egunawan | Merged in: | |
Authors: | Reviewers: | Travis Scrimshaw | |
Report Upstream: | N/A | Work issues: | |
Branch: | public/ticket/18588 (Commits, GitHub, GitLab) | Commit: | 270dc932662ce396e697f2541dae31b02e4910cc |
Dependencies: | Stopgaps: |
Description (last modified by )
Add d-vectors to ClusterSeed?
Change History (16)
comment:1 Changed 8 years ago by
Branch: | → u/etn40ff/add_d_vectors |
---|
comment:2 Changed 8 years ago by
Authors: | → Salvatore Stella |
---|---|
Commit: | → b6e225a8dd952fb267c488c7cc97cfbd56823fb2 |
Component: | PLEASE CHANGE → combinatorics |
Description: | modified (diff) |
Keywords: | Cluster Algebras SageDays 64.5 added |
Type: | PLEASE CHANGE → enhancement |
comment:3 Changed 8 years ago by
Commit: | b6e225a8dd952fb267c488c7cc97cfbd56823fb2 → d18903f10330bced19b96e56df66e38222312a0a |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
d18903f | Add d-matrix to ClusterSeed
|
comment:4 Changed 8 years ago by
Cc: | stumpc5 added |
---|---|
Status: | new → needs_review |
comment:6 Changed 8 years ago by
Commit: | d18903f10330bced19b96e56df66e38222312a0a → b2a8278e1d7a9e6d7f637ae5b5eaa92a315af258 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
b2a8278 | Removed trailing spaces
|
comment:7 Changed 8 years ago by
Status: | needs_review → needs_work |
---|
Doc should start with Return
and not Returns
The doc should start with a one sentence, one-line description. Then an empty line, then more explanations if needed.
comment:8 Changed 8 years ago by
Hi Frédéric, thank you very much for pointing this out. This ticket was made in a rush only to show how to make one to the audience of SageDays64.5 and was not polished enough. According to what happened at that workshop it is also superseded by several improvements in ClusterSeed?. I will live it as it is for the moment and push more changes later on if if they are needed. Thank S.
comment:10 Changed 8 years ago by
Cc: | egunawan added |
---|
comment:11 Changed 8 years ago by
Branch: | u/etn40ff/add_d_vectors → public/ticket/18588 |
---|---|
Commit: | b2a8278e1d7a9e6d7f637ae5b5eaa92a315af258 → 270dc932662ce396e697f2541dae31b02e4910cc |
Status: | needs_work → needs_review |
comment:13 Changed 7 years ago by
Milestone: | sage-6.8 → sage-duplicate/invalid/wontfix |
---|
Do you confirm that this can be closed as duplicate ?
If yes, please set to positive review.
comment:14 Changed 7 years ago by
Authors: | Salvatore Stella |
---|---|
Reviewers: | → Travis Scrimshaw |
Status: | needs_review → positive_review |
I agree.
comment:16 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | positive_review → closed |
New commits:
Add d-vector to ClusterSeed