Opened 8 years ago

Closed 7 years ago

#18588 closed enhancement (fixed)

Add d-vectors

Reported by: Salvatore Stella Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics Keywords: Cluster Algebras, SageDays 64.5
Cc: Christian Stump, Emily Gunawan Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: public/ticket/18588 (Commits, GitHub, GitLab) Commit: 270dc932662ce396e697f2541dae31b02e4910cc
Dependencies: Stopgaps:

Status badges

Change History (16)

comment:1 Changed 8 years ago by Salvatore Stella

Branch: u/etn40ff/add_d_vectors

comment:2 Changed 8 years ago by Salvatore Stella

Authors: Salvatore Stella
Commit: b6e225a8dd952fb267c488c7cc97cfbd56823fb2
Component: PLEASE CHANGEcombinatorics
Description: modified (diff)
Keywords: Cluster Algebras SageDays 64.5 added
Type: PLEASE CHANGEenhancement

New commits:

b6e225aAdd d-vector to ClusterSeed

comment:3 Changed 8 years ago by git

Commit: b6e225a8dd952fb267c488c7cc97cfbd56823fb2d18903f10330bced19b96e56df66e38222312a0a

Branch pushed to git repo; I updated commit sha1. New commits:

d18903fAdd d-matrix to ClusterSeed

comment:4 Changed 8 years ago by Salvatore Stella

Cc: Christian Stump added
Status: newneeds_review

comment:5 Changed 8 years ago by Christian Stump

Please remove trailing white spaces! Cheers, C#

comment:6 Changed 8 years ago by git

Commit: d18903f10330bced19b96e56df66e38222312a0ab2a8278e1d7a9e6d7f637ae5b5eaa92a315af258

Branch pushed to git repo; I updated commit sha1. New commits:

b2a8278Removed trailing spaces

comment:7 Changed 8 years ago by Frédéric Chapoton

Status: needs_reviewneeds_work

Doc should start with Return and not Returns

The doc should start with a one sentence, one-line description. Then an empty line, then more explanations if needed.

Also, please use no space after [ or before ] (by pep8 standard for formatting code)

Last edited 8 years ago by Frédéric Chapoton (previous) (diff)

comment:8 Changed 8 years ago by Salvatore Stella

Hi Frédéric, thank you very much for pointing this out. This ticket was made in a rush only to show how to make one to the audience of SageDays64.5 and was not polished enough. According to what happened at that workshop it is also superseded by several improvements in ClusterSeed?. I will live it as it is for the moment and push more changes later on if if they are needed. Thank S.

comment:9 Changed 8 years ago by Frédéric Chapoton

Then this is going to block the cluster fans in #17947.

comment:10 Changed 8 years ago by Emily Gunawan

Cc: Emily Gunawan added

comment:11 Changed 7 years ago by Frédéric Chapoton

Branch: u/etn40ff/add_d_vectorspublic/ticket/18588
Commit: b2a8278e1d7a9e6d7f637ae5b5eaa92a315af258270dc932662ce396e697f2541dae31b02e4910cc
Status: needs_workneeds_review

Here is a first review patch.


New commits:

d30fc04Merge branch 'u/etn40ff/add_d_vectors' into 6.8.b6
270dc93trac #18588 first review commit

comment:12 Changed 7 years ago by Salvatore Stella

I guess this might be considered superseded by #18594

comment:13 Changed 7 years ago by Frédéric Chapoton

Milestone: sage-6.8sage-duplicate/invalid/wontfix

Do you confirm that this can be closed as duplicate ?

If yes, please set to positive review.

comment:14 Changed 7 years ago by Travis Scrimshaw

Authors: Salvatore Stella
Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

I agree.

comment:15 Changed 7 years ago by Salvatore Stella

Me too

comment:16 Changed 7 years ago by Volker Braun

Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.