Opened 7 years ago
Closed 7 years ago
#18583 closed enhancement (fixed)
Clean up PARI declarations
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage6.8 
Component:  cython  Keywords:  
Cc:  defeo, jpflori  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  JeanPierre Flori 
Report Upstream:  N/A  Work issues:  
Branch:  f7efbfe (Commits, GitHub, GitLab)  Commit:  f7efbfe22d1cf953cace8e57f27e81be92cd6197 
Dependencies:  Stopgaps: 
Description (last modified by )
We should really clean up the declarations in sage/libs/paridecl.pxd
, analogous to what has been done for gmp
for example.
This also fixes the unneeded linking of pari
in the following Cython extensions:
src/build/cythonized/sage/rings/number_field/totallyreal.c src/build/cythonized/sage/rings/padics/common_conversion.c src/build/cythonized/sage/rings/padics/padic_capped_absolute_element.c src/build/cythonized/sage/rings/padics/padic_capped_relative_element.c src/build/cythonized/sage/rings/padics/padic_fixed_mod_element.c src/build/cythonized/sage/rings/real_double.c
Change History (11)
comment:1 Changed 7 years ago by
 Summary changed from Clean up PARI declaration to Clean up PARI declarations
comment:2 Changed 7 years ago by
 Cc defeo added
comment:3 Changed 7 years ago by
 Dependencies #18450 deleted
 Description modified (diff)
comment:4 Changed 7 years ago by
 Branch set to u/jdemeyer/clean_up_pari_declarations
comment:5 Changed 7 years ago by
 Commit set to d9c97acc74bebfb486d55a9e35263851f42e6845
 Status changed from new to needs_review
comment:6 Changed 7 years ago by
 Cc jpflori added
comment:7 Changed 7 years ago by
 Commit changed from d9c97acc74bebfb486d55a9e35263851f42e6845 to f2854be020aa0dd368ea2941ed5d589be797aa13
Branch pushed to git repo; I updated commit sha1. New commits:
f2854be  Fix paricom.h declarations

comment:8 Changed 7 years ago by
Could you just add a comment on why types.pxd
should not call any PARI function?
I guess it is to avoid the need to link to PARI when cimporting taht file, but that's not stated.
comment:9 Changed 7 years ago by
 Commit changed from f2854be020aa0dd368ea2941ed5d589be797aa13 to f7efbfe22d1cf953cace8e57f27e81be92cd6197
Branch pushed to git repo; I updated commit sha1. New commits:
f7efbfe  Comment about types.pxd

comment:10 Changed 7 years ago by
 Reviewers set to JeanPierre Flori
 Status changed from needs_review to positive_review
comment:11 Changed 7 years ago by
 Branch changed from u/jdemeyer/clean_up_pari_declarations to f7efbfe22d1cf953cace8e57f27e81be92cd6197
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Clean up PARI declarations