Opened 8 years ago

Closed 7 years ago

#18583 closed enhancement (fixed)

Clean up PARI declarations

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-6.8
Component: cython Keywords:
Cc: Luca De Feo, Jean-Pierre Flori Merged in:
Authors: Jeroen Demeyer Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: f7efbfe (Commits, GitHub, GitLab) Commit: f7efbfe22d1cf953cace8e57f27e81be92cd6197
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

We should really clean up the declarations in sage/libs/paridecl.pxd, analogous to what has been done for gmp for example.

This also fixes the unneeded linking of pari in the following Cython extensions:

src/build/cythonized/sage/rings/number_field/totallyreal.c
src/build/cythonized/sage/rings/padics/common_conversion.c
src/build/cythonized/sage/rings/padics/padic_capped_absolute_element.c
src/build/cythonized/sage/rings/padics/padic_capped_relative_element.c
src/build/cythonized/sage/rings/padics/padic_fixed_mod_element.c
src/build/cythonized/sage/rings/real_double.c

Change History (11)

comment:1 Changed 8 years ago by Jeroen Demeyer

Summary: Clean up PARI declarationClean up PARI declarations

comment:2 Changed 8 years ago by Luca De Feo

Cc: Luca De Feo added

comment:3 Changed 7 years ago by Jeroen Demeyer

Authors: Jeroen Demeyer
Dependencies: #18450
Description: modified (diff)

comment:4 Changed 7 years ago by Jeroen Demeyer

Branch: u/jdemeyer/clean_up_pari_declarations

comment:5 Changed 7 years ago by Jeroen Demeyer

Commit: d9c97acc74bebfb486d55a9e35263851f42e6845
Status: newneeds_review

New commits:

d9c97acClean up PARI declarations

comment:6 Changed 7 years ago by Jean-Pierre Flori

Cc: Jean-Pierre Flori added

comment:7 Changed 7 years ago by git

Commit: d9c97acc74bebfb486d55a9e35263851f42e6845f2854be020aa0dd368ea2941ed5d589be797aa13

Branch pushed to git repo; I updated commit sha1. New commits:

f2854beFix paricom.h declarations

comment:8 Changed 7 years ago by Jean-Pierre Flori

Could you just add a comment on why types.pxd should not call any PARI function?

I guess it is to avoid the need to link to PARI when cimporting taht file, but that's not stated.

comment:9 Changed 7 years ago by git

Commit: f2854be020aa0dd368ea2941ed5d589be797aa13f7efbfe22d1cf953cace8e57f27e81be92cd6197

Branch pushed to git repo; I updated commit sha1. New commits:

f7efbfeComment about types.pxd

comment:10 Changed 7 years ago by Jean-Pierre Flori

Reviewers: Jean-Pierre Flori
Status: needs_reviewpositive_review

comment:11 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/clean_up_pari_declarationsf7efbfe22d1cf953cace8e57f27e81be92cd6197
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.