Opened 12 years ago

Closed 12 years ago

#1858 closed defect (fixed)

[with patch; with positive review] plot.py coverage is crap -- improve it

Reported by: was Owned by: was
Priority: major Milestone: sage-2.10.1
Component: graphics Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Right now:

$ sage -coverage plot.py
----------------------------------------------------------------------
plot.py
ERROR: Please define a s == loads(dumps(s)) doctest.
SCORE plot.py: 13% (25 of 185)

Attachments (2)

trac-1858.patch (47.6 KB) - added by was 12 years ago.
trac-1858-part2.patch (859 bytes) - added by was 12 years ago.
fixes the typo nick pointed out

Download all attachments as: .zip

Change History (10)

comment:1 Changed 12 years ago by was

  • Status changed from new to assigned

comment:2 Changed 12 years ago by was

  • Summary changed from plot.py coverage is crap -- get it to 100% to plot.py coverage is crap -- improve it

after:

teragon:plot was$ sage -coverage plot.py|more
----------------------------------------------------------------------
plot.py
SCORE plot.py: 35% (64 of 180)

It's a start at least.

Changed 12 years ago by was

comment:3 Changed 12 years ago by was

  • Summary changed from plot.py coverage is crap -- improve it to [with patch; needs review] plot.py coverage is crap -- improve it

comment:4 Changed 12 years ago by ncalexan

  • Summary changed from [with patch; needs review] plot.py coverage is crap -- improve it to [with patch; with mostly positive review] plot.py coverage is crap -- improve it

The following docstring is probably wrong -- each entry is probably a float between 0 and 1, inclusive.

467	        INPUT: 
468	            c -- an rgb color 3-tuple, where each tuple entry is an 
469	                 integer between 0 and 1 

But I think this should be applied.

Changed 12 years ago by was

fixes the typo nick pointed out

comment:5 Changed 12 years ago by mabshoff

  • Summary changed from [with patch; with mostly positive review] plot.py coverage is crap -- improve it to [with patch; with positive review] plot.py coverage is crap -- improve it

Ok, since was fixed the issue this looks good to merge now.

Cheers,

Michael

comment:6 Changed 12 years ago by mabshoff

These two patches seem to depend on at least 1508 to be applied - maybe more.

Cheers,

Michael

comment:7 Changed 12 years ago by mabshoff

This patch also clashes with #1859, so I applied two hunks manually.

Cheers,

Michael

comment:8 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 2.10.1.alpha1

Note: See TracTickets for help on using tickets.