Opened 4 years ago

Closed 4 years ago

#18571 closed enhancement (fixed)

CVXOPT should not accept integer variables

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.8
Component: numerical Keywords:
Cc: dimpase Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 5f40ea3 (Commits) Commit: 5f40ea364ae190801fa0cbfb4e0bd2138c3ce87c
Dependencies: #18569 Stopgaps:

Description


Change History (9)

comment:1 Changed 4 years ago by ncohen

  • Branch set to public/18571
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by git

  • Commit set to 707d5d57278f845fff3e51f959cfb711814bb350

Branch pushed to git repo; I updated commit sha1. New commits:

d0b2291Fixed various typos, cleaned the tests
707d5d5typo fix

comment:3 Changed 4 years ago by git

  • Commit changed from 707d5d57278f845fff3e51f959cfb711814bb350 to 5f40ea364ae190801fa0cbfb4e0bd2138c3ce87c

Branch pushed to git repo; I updated commit sha1. New commits:

5f40ea3trac #18571: CVXOPT should not accept integer variables

comment:4 follow-up: Changed 4 years ago by dimpase

hmm, shouldn't this be rebased over #18569 ?

comment:5 in reply to: ↑ 4 Changed 4 years ago by dimpase

  • Status changed from needs_review to positive_review

Replying to dimpase:

hmm, shouldn't this be rebased over #18569 ?

OK, never mind. git merge does the right thing here. Looks good.

comment:6 Changed 4 years ago by ncohen

Thank you!

Nathann

comment:7 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name missing

comment:8 Changed 4 years ago by ncohen

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_work to positive_review

comment:9 Changed 4 years ago by vbraun

  • Branch changed from public/18571 to 5f40ea364ae190801fa0cbfb4e0bd2138c3ce87c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.