Opened 7 years ago

Closed 7 years ago

#18570 closed enhancement (fixed)

Cache the result of have_dot2tex

Reported by: tscrim Owned by: tscrim
Priority: major Milestone: sage-6.8
Component: performance Keywords: dot2tex
Cc: ncohen, jmantysalo Merged in:
Authors: Travis Scrimshaw Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: f930901 (Commits, GitHub, GitLab) Commit: f930901163d6e0d4760e6f8a655173dcdb430e45
Dependencies: Stopgaps:

Status badges

Description

Currently, have_dot2tex is not cached and tests for dot2tex by executing a dot2tex command on required functionality, causing unnecessary slowdown. We cache this result.

Change History (5)

comment:1 Changed 7 years ago by tscrim

  • Branch set to public/speedup_dot2tex-18570
  • Cc jmantysalo added; jori removed
  • Commit set to f930901163d6e0d4760e6f8a655173dcdb430e45
  • Status changed from new to needs_review

New commits:

​f930901Cache the result of have_dot2tex.

comment:2 Changed 7 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Thanks !

comment:3 Changed 7 years ago by tscrim

I wonder if this has gotten the fastest ticket of all time... :P

comment:4 Changed 7 years ago by ncohen

No, I have one which is below 30 seconds. Frédéric Chapoton had a ticket fixing a one-letter typo :-P

Nathann

Last edited 7 years ago by ncohen (previous) (diff)

comment:5 Changed 7 years ago by vbraun

  • Branch changed from public/speedup_dot2tex-18570 to f930901163d6e0d4760e6f8a655173dcdb430e45
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.