Opened 6 years ago

Closed 6 years ago

#18569 closed defect (fixed)

remove opt. tags for cvxopt LP

Reported by: dimpase Owned by:
Priority: major Milestone: sage-6.8
Component: linear programming Keywords:
Cc: ncohen Merged in:
Authors: Dima Pasechnik Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 707d5d5 (Commits, GitHub, GitLab) Commit: 707d5d57278f845fff3e51f959cfb711814bb350
Dependencies: Stopgaps:

Status badges

Description


Change History (7)

comment:1 Changed 6 years ago by dimpase

  • Branch set to u/dimpase/remove_opt__tags_for_cvxopt_lp

comment:2 Changed 6 years ago by dimpase

  • Cc ncohen added
  • Commit set to d0b2291190ec905bb6e6e18ac3fb1e1757eb87a6
  • Component changed from PLEASE CHANGE to linear programming
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

​d0b2291Fixed various typos, cleaned the tests

comment:3 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

``integer'' -> ``integer``

comment:4 Changed 6 years ago by git

  • Commit changed from d0b2291190ec905bb6e6e18ac3fb1e1757eb87a6 to 707d5d57278f845fff3e51f959cfb711814bb350

Branch pushed to git repo; I updated commit sha1. New commits:

​707d5d5typo fix

comment:5 Changed 6 years ago by dimpase

  • Status changed from needs_work to needs_review

oops, fixed

comment:6 Changed 6 years ago by ncohen

  • Authors set to Dima Pasechnik
  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Looks good. But if you do not mind, I will fix this 'integer variable' problem, for not raising exceptions is criminal.

Nathann

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/dimpase/remove_opt__tags_for_cvxopt_lp to 707d5d57278f845fff3e51f959cfb711814bb350
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.