Opened 8 years ago

Closed 7 years ago

#18568 closed defect (fixed)

doctest fix for wrong expansion of (x+sqrt(2)*x)^2

Reported by: Ralf Stephan Owned by:
Priority: major Milestone: sage-6.8
Component: symbolics Keywords:
Cc: Karl-Dieter Crisman Merged in:
Authors: Ralf Stephan Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 4b77d29 (Commits, GitHub, GitLab) Commit: 4b77d29010faa793e03bcad3d24370aab9a78993
Dependencies: Stopgaps:

Status badges

Description

This bug was recently fixed in GiNaC:

sage: ((x+sqrt(2)*x)^2).expand()
2*sqrt(2)*x^2 + 2*x^2 + x^2

This ticket will wait for Pynac to catch up and add a Sage doctest for the case.

Change History (8)

comment:1 Changed 8 years ago by Ralf Stephan

Summary: wrong expansion of (x+sqrt(2)*x)^2)wrong expansion of (x+sqrt(2)*x)^2

comment:2 Changed 8 years ago by Karl-Dieter Crisman

Cc: Karl-Dieter Crisman added

comment:3 Changed 7 years ago by Ralf Stephan

Branch: u/rws/wrong_expansion_of__x_sqrt_2__x__2

comment:4 Changed 7 years ago by Ralf Stephan

Commit: 4b77d29010faa793e03bcad3d24370aab9a78993
Report Upstream: Fixed upstream, in a later stable release.N/A
Status: newneeds_review
Summary: wrong expansion of (x+sqrt(2)*x)^2doctest fix for wrong expansion of (x+sqrt(2)*x)^2

New commits:

4b77d2918568: doctest fix for wrong expansion of (x+sqrt(2)*x)^2

comment:5 Changed 7 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

lgtm

comment:6 Changed 7 years ago by Volker Braun

Status: positive_reviewneeds_work

Author name is missing

comment:7 Changed 7 years ago by Ralf Stephan

Authors: Ralf Stephan
Status: needs_workpositive_review

comment:8 Changed 7 years ago by Volker Braun

Branch: u/rws/wrong_expansion_of__x_sqrt_2__x__24b77d29010faa793e03bcad3d24370aab9a78993
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.