Opened 4 years ago

Closed 4 years ago

#18568 closed defect (fixed)

doctest fix for wrong expansion of (x+sqrt(2)*x)^2

Reported by: rws Owned by:
Priority: major Milestone: sage-6.8
Component: symbolics Keywords:
Cc: kcrisman Merged in:
Authors: Ralf Stephan Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 4b77d29 (Commits) Commit: 4b77d29010faa793e03bcad3d24370aab9a78993
Dependencies: Stopgaps:

Description

This bug was recently fixed in GiNaC: 

sage: ((x+sqrt(2)*x)^2).expand()
2*sqrt(2)*x^2 + 2*x^2 + x^2

This ticket will wait for Pynac to catch up and add a Sage doctest for the case.

Change History (8)

comment:1 Changed 4 years ago by rws

  • Summary changed from wrong expansion of (x+sqrt(2)*x)^2) to wrong expansion of (x+sqrt(2)*x)^2

comment:2 Changed 4 years ago by kcrisman

  • Cc kcrisman added

comment:3 Changed 4 years ago by rws

  • Branch set to u/rws/wrong_expansion_of__x_sqrt_2__x__2

comment:4 Changed 4 years ago by rws

  • Commit set to 4b77d29010faa793e03bcad3d24370aab9a78993
  • Report Upstream changed from Fixed upstream, in a later stable release. to N/A
  • Status changed from new to needs_review
  • Summary changed from wrong expansion of (x+sqrt(2)*x)^2 to doctest fix for wrong expansion of (x+sqrt(2)*x)^2

New commits:

​4b77d2918568: doctest fix for wrong expansion of (x+sqrt(2)*x)^2

comment:5 Changed 4 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

lgtm

comment:6 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Author name is missing

comment:7 Changed 4 years ago by rws

  • Authors set to Ralf Stephan
  • Status changed from needs_work to positive_review

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/rws/wrong_expansion_of__x_sqrt_2__x__2 to 4b77d29010faa793e03bcad3d24370aab9a78993
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.