Opened 6 years ago
Closed 6 years ago
#18563 closed defect (fixed)
Change known-broken new-style packages to "experimental"
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.8 |
Component: | packages: experimental | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | 245ab15 (Commits) | Commit: | 245ab151fe517da0eb2a982494376a20441304f4 |
Dependencies: | Stopgaps: |
Description (last modified by )
Packages which are known to fail optional doctests or which do not install on all supported platforms should be "experimental", not "optional".
Packages moved to experimental:
4ti2
: doesn't pass optional doctestsautotools
: breaks installation of Singular ifxz
is not installedcompilerwrapper
: totally breaks building Sage on OS Xfricas
: doesn't pass optional doctestsgap_packages
: doesn't pass optional doctestslatte_int
: doesn't pass optional docteststopcom
: doesn't pass doctests, even breaks non-optional testsvalgrind
: doesn't build on OS X 10.10
Other problematic packages, not changed here:
Change History (22)
comment:1 Changed 6 years ago by
- Branch set to u/jdemeyer/change_known_broken_packages_to__experimental_
comment:2 Changed 6 years ago by
- Commit set to ef11087ea5d80f77d3d783abcc3301f8d41755ab
- Description modified (diff)
comment:3 Changed 6 years ago by
needs review ?
comment:4 in reply to: ↑ description ; follow-up: ↓ 5 Changed 6 years ago by
- Summary changed from Change known-broken packages to "experimental" to Change known-broken new-style packages to "experimental"
Replying to jdemeyer:
NOTE replicate the changes on Sage's mirrors (ask Harald) when this patch is merged
I plan to consider only new-style packages in this ticket, is the mirror thing still relevant?
comment:5 in reply to: ↑ 4 Changed 6 years ago by
- Description modified (diff)
I plan to consider only new-style packages in this ticket, is the mirror thing still relevant?
Indeed, in this case you don't need to.
Nathann
comment:6 Changed 6 years ago by
- Commit changed from ef11087ea5d80f77d3d783abcc3301f8d41755ab to 37fd68966756365cd330e1eeba3b9beb332d6f81
Branch pushed to git repo; I updated commit sha1. New commits:
37fd689 | Valgrind doesn't build on OS X 10.10
|
comment:7 Changed 6 years ago by
- Description modified (diff)
comment:8 follow-up: ↓ 9 Changed 6 years ago by
What's wrong with Valgrind? I just compiled it on this machine:
simulote:valgrind-3.10.0 ncohen$ uname -a Darwin simulote 13.4.0 Darwin Kernel Version 13.4.0: Sun Aug 17 19:50:11 PDT 2014; root:xnu-2422.115.4~1/RELEASE_X86_64 x86_64
Did you keep the log? I'd be interested to look at them.
comment:9 in reply to: ↑ 8 ; follow-up: ↓ 10 Changed 6 years ago by
Replying to ncohen:
What's wrong with Valgrind? I just compiled it on this machine:
simulote:valgrind-3.10.0 ncohen$ uname -a Darwin simulote 13.4.0 Darwin Kernel Version 13.4.0: Sun Aug 17 19:50:11 PDT 2014; root:xnu-2422.115.4~1/RELEASE_X86_64 x86_64
That's OS X 10.9 which is indeed fine. The problem is that it explicitly does not work on OS X 10.10:
checking for a supported OS... ok (darwin14.3.0) checking for the kernel version... unsupported (14.3.0) configure: error: Valgrind works on Darwin 10.x, 11.x, 12.x and 13.x (Mac OS X 10.6/7/8/9) Error configuring Valgrind
See also http://stackoverflow.com/questions/26564125/yosemite-and-valgrind for example.
comment:10 in reply to: ↑ 9 ; follow-up: ↓ 11 Changed 6 years ago by
That's OS X 10.9 which is indeed fine. The problem is that it explicitly does not work on OS X 10.10:
Funny. Well, anyway they seem to say that the latest svn version handles it. Good news.
Oh, by the way I am about write a ticket so that sage -i <experimental_package>
shows the same warning we have when the package is a new-style package.
Nathann
comment:11 in reply to: ↑ 10 Changed 6 years ago by
Oh, by the way I am about write a ticket so that
sage -i <experimental_package>
shows the same warning we have when the package is a new-style package.
Done at #18566
Nathann
comment:12 follow-up: ↓ 14 Changed 6 years ago by
Something else: I think we should invent a new category "alternative
" for packages python2
, python3
, gmp
, mpir
which are essentially standard but shouldn't be installed at the same time. If you agree, I will create a new ticket for this.
comment:13 Changed 6 years ago by
Aargh... I installed compilerwrapper
on OS X and it totally broke everything. Another package to move to "experimental". Restarting after make distclean
...
comment:14 in reply to: ↑ 12 ; follow-up: ↓ 15 Changed 6 years ago by
Something else: I think we should invent a new category "
alternative
" for packagespython2
,python3
,gmp
,mpir
which are essentially standard but shouldn't be installed at the same time. If you agree, I will create a new ticket for this.
I cannot say that I like this much. We already have base/standard/optional/experimental packages, old-style spkgs and new-style spkgs. What would be the advantage of alternative packages?
Nathann
comment:15 in reply to: ↑ 14 ; follow-up: ↓ 16 Changed 6 years ago by
Replying to ncohen:
What would be the advantage of alternative packages?
I want to be able to install all optional packages without breaking anything.
comment:16 in reply to: ↑ 15 Changed 6 years ago by
I want to be able to install all optional packages without breaking anything.
What about adding a couple of lines in their spkg-install
script to detect when that happens?
comment:17 Changed 6 years ago by
- Commit changed from 37fd68966756365cd330e1eeba3b9beb332d6f81 to 3a3fe9e7429959af51f45a0767720d4830239ba7
Branch pushed to git repo; I updated commit sha1. New commits:
3a3fe9e | Compilerwrapper and custom GCC don't go well together
|
comment:18 Changed 6 years ago by
- Commit changed from 3a3fe9e7429959af51f45a0767720d4830239ba7 to 245ab151fe517da0eb2a982494376a20441304f4
Branch pushed to git repo; I updated commit sha1. New commits:
245ab15 | Newer libtool versions require xz
|
comment:19 Changed 6 years ago by
- Description modified (diff)
comment:20 Changed 6 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:21 Changed 6 years ago by
- Reviewers set to Nathann Cohen
- Status changed from needs_review to positive_review
comment:22 Changed 6 years ago by
- Branch changed from u/jdemeyer/change_known_broken_packages_to__experimental_ to 245ab151fe517da0eb2a982494376a20441304f4
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Change known-broken packages to "experimental"