Opened 4 years ago

Closed 4 years ago

#18559 closed defect (fixed)

Rewrite "optional Coin" as "optional cbc"

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.8
Component: numerical Keywords:
Cc: jdemeyer Merged in:
Authors: Nathann Cohen Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 4222223 (Commits) Commit: 4222223bae0cccb491ab3023774745b043263644
Dependencies: Stopgaps:

Description

Coin is not a sage package, but cbc is.

Nathann

Change History (8)

comment:1 Changed 4 years ago by ncohen

  • Branch set to public/18559
  • Commit set to 6d6277f7264b32f743a40417e5268dce5d7e682d
  • Status changed from new to needs_review

New commits:

6d6277ftrac #18559: Rewrite "optional Coin" as "optional cbc"

comment:2 Changed 4 years ago by chapoton

  • Status changed from needs_review to needs_work

Tests do not pass

"hey"

is not the expected answer

comment:3 Changed 4 years ago by ncohen

I'm an idiot. I was testing things :-P

I'll update it in a second.

Nathann

comment:4 Changed 4 years ago by ncohen

  • Status changed from needs_work to needs_review

comment:5 Changed 4 years ago by git

  • Commit changed from 6d6277f7264b32f743a40417e5268dce5d7e682d to 4222223bae0cccb491ab3023774745b043263644

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4222223trac #18559: Rewrite "optional Coin" as "optional cbc"

comment:6 Changed 4 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, good to go

comment:7 Changed 4 years ago by ncohen

Thanks !

comment:8 Changed 4 years ago by vbraun

  • Branch changed from public/18559 to 4222223bae0cccb491ab3023774745b043263644
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.