Opened 4 years ago

Closed 4 years ago

#18557 closed enhancement (fixed)

Implement FiniteStateMachine.disjoint_union (and .__or__)

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-6.8
Component: finite state machines Keywords: union, or
Cc: skropf, dkrenn, slabbe Merged in:
Authors: Clemens Heuberger Reviewers: Sara Kropf
Report Upstream: N/A Work issues:
Branch: fee74b1 (Commits) Commit: fee74b1e0e2e372bde97f3e71107da1f98688d1f
Dependencies: #18556 Stopgaps:

Description

Implement FiniteStateMachine.disjoint_union and FiniteStateMachine.__or__.

Change History (7)

comment:1 Changed 4 years ago by cheuberg

  • Branch set to u/cheuberg/fsm/disjoint-union
  • Commit set to ff3a5d8dd34e337dfb885e8b3323276813d30cab
  • Dependencies set to #18556
  • Status changed from new to needs_review

New commits:

​ea021ccTrac #18556: FiniteStateMachine.is_deterministic: several initial states
​ff3a5d8Trac #18557: Implement FiniteStateMachine.disjoint_union (and .__or__)

comment:2 Changed 4 years ago by skropf

  • Branch changed from u/cheuberg/fsm/disjoint-union to u/skropf/fsm/disjoint-union

comment:3 Changed 4 years ago by skropf

  • Commit changed from ff3a5d8dd34e337dfb885e8b3323276813d30cab to a89d3eacd542878fba7b6037412095a3aafeafb4
  • Reviewers set to Sara Kropf

For me this is fine. In the documentation, it would be nice to remark about using | and + alternatively.

New commits:

​a89d3eaTrac #18557: One typo

comment:4 Changed 4 years ago by cheuberg

  • Branch changed from u/skropf/fsm/disjoint-union to u/cheuberg/fsm/disjoint-union

comment:5 Changed 4 years ago by git

  • Commit changed from a89d3eacd542878fba7b6037412095a3aafeafb4 to fee74b1e0e2e372bde97f3e71107da1f98688d1f

Branch pushed to git repo; I updated commit sha1. New commits:

​fee74b1Trac #18557: Remark on alternative notation in documentation

comment:6 Changed 4 years ago by skropf

  • Status changed from needs_review to positive_review

Thank you, I set it to positive review now.

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/disjoint-union to fee74b1e0e2e372bde97f3e71107da1f98688d1f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.