Opened 6 years ago

Closed 6 years ago

#18553 closed enhancement (fixed)

Python 3: The semantic of map() function is changed (addendum 2)

Reported by: wluebbe Owned by:
Priority: major Milestone: sage-6.8
Component: misc Keywords: python3
Cc: aapitzsch Merged in:
Authors: Wilfried Luebbe Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: 21537ab (Commits, GitHub, GitLab) Commit: 21537ab05c501dc73eb52e3d2297bce2cb6f7440
Dependencies: Stopgaps:

Status badges

Description

This ticket is part of #16073 to simplify review. In Py2 map() returns a list, while in Py3 map() returns an iterator.

Change History (9)

comment:1 follow-up: Changed 6 years ago by wluebbe

  • Authors set to Wilfried Luebbe
  • Status changed from new to needs_review

Another batch of corrections to map().

comment:2 in reply to: ↑ 1 Changed 6 years ago by aapitzsch

  • Status changed from needs_review to needs_work

Replying to wluebbe:

Another batch of corrections to map().

Where? There is no branch attached.

comment:3 Changed 6 years ago by wluebbe

  • Branch set to u/wluebbe/18553
  • Commit set to 98d32635dc5e4ebe10a87d9056c76d0e7ef0efcc

Now there is a branch :-/


New commits:

98d3263Trac #18553: The semantic of map() function is changed in Python 3

comment:4 Changed 6 years ago by wluebbe

  • Status changed from needs_work to needs_review

comment:5 Changed 6 years ago by aapitzsch

Could you change in src/sage/geometry/fan.py

-        facets = [frozenset(_) for _ in [c.ambient_ray_indices() for c in self.generating_cones()] ]
+        facets = [frozenset(c.ambient_ray_indices()) for c in self.generating_cones()]

comment:6 Changed 6 years ago by git

  • Commit changed from 98d32635dc5e4ebe10a87d9056c76d0e7ef0efcc to 21537ab05c501dc73eb52e3d2297bce2cb6f7440

Branch pushed to git repo; I updated commit sha1. New commits:

21537abImplement an improvement as suggested by the reviewer.

comment:7 Changed 6 years ago by wluebbe

Done. Thanx!

comment:8 Changed 6 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

LGTM.

comment:9 Changed 6 years ago by vbraun

  • Branch changed from u/wluebbe/18553 to 21537ab05c501dc73eb52e3d2297bce2cb6f7440
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.