Changes between Version 44 and Version 52 of Ticket #18529


Ignore:
Timestamp:
11/09/15 10:46:07 (4 years ago)
Author:
egourgoulhon
Comment:

The above commit takes into account this discussion on sage-devel, as well as the first recommendation of Travis in comment:41 : it removes UniqueRepresentation for manifolds and charts, leaving only WithEqualityById. Some methods _test_pickling have been introduced. They are weaker than SageObject._test_pickling in the sense that they do not demand loads(dumps(M)) == M (which equality-by-id forbids without any unique representation). However, these local _test_pickling methods perform non trivial tests: they guarantee that loads(dumps(M)) proceeds without any error and they check the identity of some characteristics between the unpickled object and the original one. All the test suites are passed.

In addition the above commit takes into account the recommendation of Jeroen in comment:49.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18529

    • Property Commit changed from 902908b41a95d3455bfcc497997ad2054c530a96 to 252e616cc053a3b76ee563282222507cd78c9fb8
  • Ticket #18529 – Description

    v44 v52  
    1111- `CoordChange`: transition map between two charts of a topological manifold
    1212
    13 `TopologicalManifold` is intended to serve as a base class for specific manifolds, like smooth manifolds (''K''='''R''') and complex manifolds (''K''='''C''').
     13`TopologicalManifold` is intended to serve as a base class for specific manifolds, like smooth manifolds (''K''='''R''') and complex manifolds (''K''='''C'''). The follow-up ticket, implementing continuous functions to the base field, is #18640.
    1414
    1515'''Documentation''':