Opened 6 years ago

Closed 6 years ago

#18519 closed enhancement (fixed)

Remove cdefs.pxi from .pxd/.pxi files

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.8
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: 11bd576 (Commits, GitHub, GitLab) Commit: 11bd5768c30e5e0c1d4d91ea730bcad7a2b6af49
Dependencies: #18455 Stopgaps:

Status badges

Description (last modified by jdemeyer)

To continue #18455, we remove cdefs.pxi from all .pxi/.pxd files.

We also fold fplll.pxi and singular-cdefs.pxi in the corresponding .pxd files.

Change History (8)

comment:1 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/18519

comment:3 Changed 6 years ago by jdemeyer

  • Commit set to 1accad6c25198c6d2c412ef1d2f593f11faa5db4
  • Status changed from new to needs_review
  • Summary changed from Remove cdefs.pxi from .pxd/.pxi to Remove cdefs.pxi from .pxd/.pxi files

New commits:

​2ed346bRemove unneeded inclusions of cdefs.pxi
​57e9278More removals of cdefs.pxi
​370106dEven more removals of cdefs
​1accad6Remove cdefs.pxi from .pxd/.pxi files

comment:4 Changed 6 years ago by mmezzarobba

In the following comment (moved from singular-cdefs.pxi to singular/decl.pxd), is “deferences” a typo for “references” or a technical term I don't know? 

+NOTE: our ring, poly etc. types are not the SINGULAR ring, poly,
+etc. types. They are deferences. So a SINGULAR ring is a ring pointer
+here.

comment:5 Changed 6 years ago by jdemeyer

I think it's a typo for "dereferences" although I don't know if that is a correct noun.

comment:6 Changed 6 years ago by git

  • Commit changed from 1accad6c25198c6d2c412ef1d2f593f11faa5db4 to 11bd5768c30e5e0c1d4d91ea730bcad7a2b6af49

Branch pushed to git repo; I updated commit sha1. New commits:

​11bd576Clarify note

comment:7 Changed 6 years ago by mmezzarobba

  • Reviewers set to Marc Mezzarobba
  • Status changed from needs_review to positive_review

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/18519 to 11bd5768c30e5e0c1d4d91ea730bcad7a2b6af49
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.