Opened 8 years ago
Closed 8 years ago
#18519 closed enhancement (fixed)
Remove cdefs.pxi from .pxd/.pxi files
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.8 |
Component: | cython | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | Marc Mezzarobba |
Report Upstream: | N/A | Work issues: | |
Branch: | 11bd576 (Commits, GitHub, GitLab) | Commit: | 11bd5768c30e5e0c1d4d91ea730bcad7a2b6af49 |
Dependencies: | #18455 | Stopgaps: |
Description (last modified by )
To continue #18455, we remove cdefs.pxi
from all .pxi
/.pxd
files.
We also fold fplll.pxi
and singular-cdefs.pxi
in the corresponding .pxd
files.
Change History (8)
comment:1 Changed 8 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 8 years ago by
Branch: | → u/jdemeyer/ticket/18519 |
---|
comment:3 Changed 8 years ago by
Commit: | → 1accad6c25198c6d2c412ef1d2f593f11faa5db4 |
---|---|
Status: | new → needs_review |
Summary: | Remove cdefs.pxi from .pxd/.pxi → Remove cdefs.pxi from .pxd/.pxi files |
comment:4 Changed 8 years ago by
In the following comment (moved from singular-cdefs.pxi
to singular/decl.pxd
), is “deferences” a typo for “references” or a technical term I don't know?
+NOTE: our ring, poly etc. types are not the SINGULAR ring, poly, +etc. types. They are deferences. So a SINGULAR ring is a ring pointer +here.
comment:5 Changed 8 years ago by
I think it's a typo for "dereferences" although I don't know if that is a correct noun.
comment:6 Changed 8 years ago by
Commit: | 1accad6c25198c6d2c412ef1d2f593f11faa5db4 → 11bd5768c30e5e0c1d4d91ea730bcad7a2b6af49 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
11bd576 | Clarify note
|
comment:7 Changed 8 years ago by
Reviewers: | → Marc Mezzarobba |
---|---|
Status: | needs_review → positive_review |
comment:8 Changed 8 years ago by
Branch: | u/jdemeyer/ticket/18519 → 11bd5768c30e5e0c1d4d91ea730bcad7a2b6af49 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
Remove unneeded inclusions of cdefs.pxi
More removals of cdefs.pxi
Even more removals of cdefs
Remove cdefs.pxi from .pxd/.pxi files