Opened 6 years ago

Last modified 6 years ago

#18517 closed enhancement

Clean up build/install after #17607 — at Version 4

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.8
Component: build Keywords:
Cc: ohanar, vbraun, ncohen Merged in:
Authors: Jeroen Demeyer Reviewers:
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/clean_up_build_install_after__17607 (Commits, GitHub, GitLab) Commit: 7e5095c53fd9575a4abbbc7bbb6a219af431bbb8
Dependencies: #17607 Stopgaps:

Status badges

Description (last modified by jdemeyer)

Instead of creating totally new package types like python2standard, adding the following lines in build/install is sufficient to implement #17607:

if [ "$SAGE_PYTHON3" = yes ]; then
    echo >&5 'PYTHON = $(PYTHON3)'
else
    echo >&5 'PYTHON = $(PYTHON2)'
fi

Change History (4)

comment:1 Changed 6 years ago by jdemeyer

  • Dependencies set to #17607

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/clean_up_build_install_after__17607

comment:3 Changed 6 years ago by git

  • Commit set to 7e5095c53fd9575a4abbbc7bbb6a219af431bbb8

Branch pushed to git repo; I updated commit sha1. New commits:

7e5095cUse $MAKE instead of make

comment:4 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from new to needs_review
Note: See TracTickets for help on using tickets.