Opened 6 years ago

Closed 6 years ago

#18517 closed enhancement (fixed)

Clean up build/install after #17607

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.8
Component: build Keywords:
Cc: ohanar, vbraun, ncohen Merged in:
Authors: Jeroen Demeyer Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 7e5095c (Commits, GitHub, GitLab) Commit: 7e5095c53fd9575a4abbbc7bbb6a219af431bbb8
Dependencies: #17607 Stopgaps:

Status badges

Description (last modified by jdemeyer)

Instead of creating totally new package types like python2standard, adding the following lines in build/install is sufficient to implement #17607: 

if [ "$SAGE_PYTHON3" = yes ]; then
    echo >&5 'PYTHON = $(PYTHON3)'
else
    echo >&5 'PYTHON = $(PYTHON2)'
fi

Change History (8)

comment:1 Changed 6 years ago by jdemeyer

  • Dependencies set to #17607

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/clean_up_build_install_after__17607

comment:3 Changed 6 years ago by git

  • Commit set to 7e5095c53fd9575a4abbbc7bbb6a219af431bbb8

Branch pushed to git repo; I updated commit sha1. New commits:

​7e5095cUse $MAKE instead of make

comment:4 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from new to needs_review

comment:5 follow-up: Changed 6 years ago by ncohen

Looks good to me. Should we rename the packages from python to python2 and from Python to python3 in this ticket?

Nathann

Last edited 6 years ago by ncohen (previous) (diff)

comment:6 in reply to: ↑ 5 ; follow-up: Changed 6 years ago by jdemeyer

Replying to ncohen:

Should we rename the packages from python to python2 and from Python to python3 in this ticket?

I prefer not.

comment:7 in reply to: ↑ 6 Changed 6 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

I prefer not.

I don't see why, but so be it.

Nathann

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/clean_up_build_install_after__17607 to 7e5095c53fd9575a4abbbc7bbb6a219af431bbb8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.