Changes between Version 136 and Version 149 of Ticket #18514


Ignore:
Timestamp:
10/04/16 11:04:17 (4 years ago)
Author:
SimonKing
Comment:

If MeatAxe was a standard spkg (which might actually be something to consider) and the SmallGroups library was GPL compatible (something which the authors refuse), I could promote the modular group cohomology computation as a new standard package: With the changes that I just pushed, all tests pass (on my machine at least), and moreover the computations have still become faster.

I have changed the status to "needs info", stating my information request in the ticket description.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18514

    • Property Status changed from needs_work to needs_info
    • Property Dependencies changed from #12103 to #12103 #21437
    • Property Branch changed from to u/SimonKing/upgrade_of_group_cohomology_spkg
    • Property Commit changed from to 54e1a0071d54fe3bc6189e2faa3af5d956b67f2a
  • Ticket #18514 – Description

    v136 v149  
    1515- The tests avoid side-effects by using a reset function. Hence, no custom doc tester is needed.
    1616- In some way (perhaps using google-style docstrings) the docs are built.
     17
     18'''__What info do I need to finish work__'''
     19
     20- Please point me to an example of a new style spkg that builds a C library ''and'' Cython modules (not in Sage's src tree) that link against the library. I want to know how it is done right (in my old spkg, it was certainly not done totally right).
     21- Please point me to an example of a new style spkg that builds documentation based on doc strings in the Cython code. This definitely isn't done well in my old style spkg. I would prefer !SageMath doc formatting, but wouldn't mind too much to change everything to, say, google formatting.