Opened 4 years ago

Closed 4 years ago

#18504 closed defect (fixed)

Git-Trac documentation does not mention git commit

Reported by: ursula Owned by:
Priority: major Milestone: sage-6.8
Component: documentation Keywords:
Cc: Merged in:
Authors: Ursula Whitcher Reviewers: Travis Scholl
Report Upstream: N/A Work issues:
Branch: 565e559 (Commits) Commit: 565e559bd727c26d27ac1cdc4b5df9ee2e6ef2a8
Dependencies: Stopgaps:

Description

The documentation for "Collaborative Development with Git-Trac" at

http://doc.sagemath.org/html/en/developer/git_trac.html

does not mention the git commit command. Therefore, following these instructions literally will result in the creation and publication of empty trac tickets.

Change History (4)

comment:1 Changed 4 years ago by ursula

  • Branch set to u/ursula/git_trac_documentation_does_not_mention_git_commit

comment:2 Changed 4 years ago by ursula

  • Authors set to Ursula Whitcher
  • Commit set to 565e559bd727c26d27ac1cdc4b5df9ee2e6ef2a8
  • Status changed from new to needs_review

New commits:

565e559Added "making changes" section with references to earlier devel doc.

comment:3 Changed 4 years ago by tscholl2

  • Reviewers set to Travis Scholl
  • Status changed from needs_review to positive_review

I think this is a great addition to the git documentation for Sage development.

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/ursula/git_trac_documentation_does_not_mention_git_commit to 565e559bd727c26d27ac1cdc4b5df9ee2e6ef2a8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.