Opened 7 years ago
Closed 7 years ago
#18493 closed defect (fixed)
Fix LS plotting
Reported by: | tscrim | Owned by: | sage-combinat |
---|---|---|---|
Priority: | major | Milestone: | sage-6.8 |
Component: | combinatorics | Keywords: | LS paths, root system plot |
Cc: | sage-combinat, bsalisbury1 | Merged in: | |
Authors: | Travis Scrimshaw | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | 57760dc (Commits, GitHub, GitLab) | Commit: | 57760dc02daef54ed4ee538b7790d62963c8d606 |
Dependencies: | Stopgaps: |
Description
Each element in the tuple representing an LS path is not a point in the piecewise-linear path, but the change in the path. This fixes my misunderstanding for the plotting.
Change History (5)
comment:1 Changed 7 years ago by
- Branch set to public/combinat/fix_ls_plots-18493
- Commit set to 57760dc02daef54ed4ee538b7790d62963c8d606
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
lgtm
comment:3 Changed 7 years ago by
Thanks Frédéric.
comment:4 Changed 7 years ago by
My pleasure. It you have a little time, could you consider looking at #18446 ?
comment:5 Changed 7 years ago by
- Branch changed from public/combinat/fix_ls_plots-18493 to 57760dc02daef54ed4ee538b7790d62963c8d606
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Easy fix at least.
New commits:
Fixing my lack of understanding of LS path elements.