Opened 7 years ago
Closed 7 years ago
#18492 closed defect (fixed)
sage's setup.py breaks on python 3
Reported by: | ohanar | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.8 |
Component: | build | Keywords: | |
Cc: | Merged in: | ||
Authors: | R. Andrew Ohana | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | 208f751 (Commits, GitHub, GitLab) | Commit: | 208f7516c794d42f94a05f2edaeb44737167b42b |
Dependencies: | Stopgaps: |
Description
Mostly trivially.
Change History (15)
comment:1 Changed 7 years ago by
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
- Status changed from needs_review to needs_work
comment:3 follow-up: ↓ 4 Changed 7 years ago by
Isn't there a Python-3 equivalent of
sys.stdout = os.fdopen(sys.stdout.fileno(), 'w', 0)
Changing the print
statement is not equivalent to changing stdout
.
comment:4 in reply to: ↑ 3 Changed 7 years ago by
Replying to jdemeyer:
Isn't there a Python-3 equivalent of
sys.stdout = os.fdopen(sys.stdout.fileno(), 'w', 0)Changing the
stdout
.
I agree, but no there isn't a python 3 equivalent: python 3 requires sys.stdout
to be buffered, unless you start python with the -u
(but you can also do that with python 2).
comment:5 follow-up: ↓ 6 Changed 7 years ago by
Not sure, but isn't there something possible with sys.stdout.buffer
in Python 3?
comment:6 in reply to: ↑ 5 Changed 7 years ago by
Replying to jdemeyer:
Not sure, but isn't there something possible with
sys.stdout.buffer
in Python 3?
It allows you to write bytes to stdout: sys.stdout.buffer
is a BytesIO
interface to stdout, whereas sys.stdout
is a StringIO
interface to stdout.
comment:7 Changed 7 years ago by
- Commit changed from cd33340d6aa67576520e644987bc369fcbefea1e to 2c9f70be2399489450250e5c166449e349d88882
comment:8 Changed 7 years ago by
- Status changed from needs_work to needs_review
comment:9 Changed 7 years ago by
- Commit changed from 2c9f70be2399489450250e5c166449e349d88882 to 6b854d92b8e6e0ef2b802b5b17cb23a7e1fd7963
comment:10 Changed 7 years ago by
- Reviewers set to Jeroen Demeyer
- Status changed from needs_review to positive_review
Assuming that you actually tested this, positive_review since the diff looks good.
comment:11 Changed 7 years ago by
- Status changed from positive_review to needs_work
Apparently you haven't actually (doc-)tested it ;-)
comment:12 Changed 7 years ago by
- Commit changed from 6b854d92b8e6e0ef2b802b5b17cb23a7e1fd7963 to 208f7516c794d42f94a05f2edaeb44737167b42b
comment:13 Changed 7 years ago by
- Status changed from needs_work to needs_review
Little hard to doctest on python 3 at the moment :)
comment:14 Changed 7 years ago by
- Status changed from needs_review to positive_review
comment:15 Changed 7 years ago by
- Branch changed from u/ohanar/python3setuppy to 208f7516c794d42f94a05f2edaeb44737167b42b
- Resolution set to fixed
- Status changed from positive_review to closed
six
should be mentioned as dependency ofsage
inbuild/deps
.