Opened 5 years ago

Closed 5 years ago

#18491 closed enhancement (fixed)

Posets: Minor docstring polishing to min and max elements

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-6.8
Component: combinatorics Keywords:
Cc: ncohen Merged in:
Authors: Jori Mäntysalo Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 3df9b4e (Commits) Commit: 3df9b4eea38213b92776a004405748bd864f0772
Dependencies: Stopgaps:

Description

Some crosslinking.

Change History (9)

comment:1 Changed 5 years ago by jmantysalo

  • Branch set to u/jmantysalo/posets__minor_docstring_polishing_to_min_and_max_elements

comment:2 Changed 5 years ago by jmantysalo

  • Cc ncohen added
  • Commit set to 597091b98368605f8cef3dc576edff9dd8d5c21d
  • Milestone changed from sage-wishlist to sage-6.8
  • Status changed from new to needs_review

Happen this one never be reviewed, no animals will be harm.


New commits:

597091bCrosslinks. One typo. No code changes.

comment:3 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

lgtm

comment:4 Changed 5 years ago by chapoton

  • Status changed from positive_review to needs_work

comment:5 Changed 5 years ago by chapoton

wrong doc in has_bottom

comment:6 Changed 5 years ago by git

  • Commit changed from 597091b98368605f8cef3dc576edff9dd8d5c21d to 3df9b4eea38213b92776a004405748bd864f0772

Branch pushed to git repo; I updated commit sha1. New commits:

3df9b4eMaximal -> minimal.

comment:7 Changed 5 years ago by jmantysalo

  • Status changed from needs_work to needs_review

Duh. Corrected.

comment:8 Changed 5 years ago by chapoton

  • Status changed from needs_review to positive_review

good now

comment:9 Changed 5 years ago by vbraun

  • Branch changed from u/jmantysalo/posets__minor_docstring_polishing_to_min_and_max_elements to 3df9b4eea38213b92776a004405748bd864f0772
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.