Opened 14 years ago

Last modified 4 years ago

#1848 new defect

Elliptic curve Sha an documentation misleading about proof

Reported by: was Owned by: was
Priority: major Milestone: sage-8.2
Component: elliptic curves Keywords:
Cc: cremona Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The sha an function:

sage: E = EllipticCurve('37a')
sage: Sha = E.sha(); Sha
<class 'sage.schemes.elliptic_curves.sha.Sha'>
sage: Sha.an()
1    

has help that at the beginning misleadingly suggests that it is provably correct when the analytic rank is 1. Looking at the code, it is clear that currently it is not provably correct except when the rank is 0 and a Manin constant hypothesis holds (which does hold for Cremona's curves).

Fix:

  1. Have a proof=False flag that keeps the current implementation
  2. Have a proof=True flag that fails if the Manin constant isn't known by a theorem to be <=2, and which runs new provably correct code in the case of analytic rank 1.

Change History (7)

comment:1 Changed 14 years ago by was

  • Status changed from new to assigned

comment:2 Changed 12 years ago by davidloeffler

  • Component changed from number theory to elliptic curves

comment:3 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:4 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:5 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:6 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:7 Changed 4 years ago by chapoton

  • Cc cremona added
  • Milestone changed from sage-6.4 to sage-8.2
  • Report Upstream set to N/A
Note: See TracTickets for help on using tickets.